DevTools: Open new tab with correct url rather than navigate from default page

BUG=374462

Review URL: https://codereview.chromium.org/398623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288035 0039d316-1c4b-4281-b951-d872f2087c98
parent 3dfc99cc
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_iterator.h" #include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/host_desktop.h" #include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/tabs/tab_strip_model.h"
...@@ -101,25 +102,13 @@ std::string BrowserListTabContentsProvider::GetPageThumbnailData( ...@@ -101,25 +102,13 @@ std::string BrowserListTabContentsProvider::GetPageThumbnailData(
scoped_ptr<DevToolsTarget> scoped_ptr<DevToolsTarget>
BrowserListTabContentsProvider::CreateNewTarget(const GURL& url) { BrowserListTabContentsProvider::CreateNewTarget(const GURL& url) {
const BrowserList* browser_list = chrome::NavigateParams params(ProfileManager::GetLastUsedProfile(),
BrowserList::GetInstance(host_desktop_type_); url, content::PAGE_TRANSITION_AUTO_TOPLEVEL);
WebContents* web_contents; params.disposition = NEW_FOREGROUND_TAB;
if (browser_list->empty()) { chrome::Navigate(&params);
chrome::NewEmptyWindow(ProfileManager::GetLastUsedProfile(), if (!params.target_contents)
host_desktop_type_); return scoped_ptr<DevToolsTarget>();
if (browser_list->empty()) content::RenderViewHost* rvh = params.target_contents->GetRenderViewHost();
return scoped_ptr<DevToolsTarget>();
web_contents =
browser_list->get(0)->tab_strip_model()->GetActiveWebContents();
web_contents->GetController().LoadURL(url,
content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
} else {
web_contents = chrome::AddSelectedTabWithURL(
browser_list->get(0),
url,
content::PAGE_TRANSITION_LINK);
}
content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
if (!rvh) if (!rvh)
return scoped_ptr<DevToolsTarget>(); return scoped_ptr<DevToolsTarget>();
return scoped_ptr<DevToolsTarget>( return scoped_ptr<DevToolsTarget>(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment