Remove unused plugin argument to skip virtual method checks in .cc files

BUG=115047

Review URL: https://codereview.chromium.org/592223002

Cr-Commit-Position: refs/heads/master@{#296159}

tools/clang/plugins/FindBadConstructsAction.cpp

@@ -26,10 +26,7 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
   bool parsed = true;
 
   for (size_t i = 0; i < args.size() && parsed; ++i) {
-    if (args[i] == "skip-virtuals-in-implementations") {
-      // TODO(rsleevi): Remove this once http://crbug.com/115047 is fixed.
-      options_.check_virtuals_in_implementations = false;
-    } else if (args[i] == "check-base-classes") {
+    if (args[i] == "check-base-classes") {
       // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
       options_.check_base_classes = true;
     } else if (args[i] == "check-weak-ptr-factory-order") {

tools/clang/plugins/FindBadConstructsConsumer.cpp

@@ -101,13 +101,11 @@ void FindBadConstructsConsumer::CheckChromeClass(SourceLocation record_location,
     CheckCtorDtorWeight(record_location, record);
   }
 
-  if (!implementation_file || options_.check_virtuals_in_implementations) {
-    bool warn_on_inline_bodies = !implementation_file;
+  bool warn_on_inline_bodies = !implementation_file;
 
-    // Check that all virtual methods are marked accordingly with both
-    // virtual and OVERRIDE.
-    CheckVirtualMethods(record_location, record, warn_on_inline_bodies);
-  }
+  // Check that all virtual methods are marked accordingly with both
+  // virtual and OVERRIDE.
+  CheckVirtualMethods(record_location, record, warn_on_inline_bodies);
 
   CheckRefCountedDtors(record_location, record);
 

tools/clang/plugins/Options.h

@@ -10,12 +10,10 @@ namespace chrome_checker {
 struct Options {
   Options()
       : check_base_classes(false),
-        check_virtuals_in_implementations(true),
         check_weak_ptr_factory_order(false),
         check_enum_last_value(false) {}
 
   bool check_base_classes;
-  bool check_virtuals_in_implementations;
   bool check_weak_ptr_factory_order;
   bool check_enum_last_value;
 };