Commit 3591ffe6 authored by Chris Mumford's avatar Chris Mumford Committed by Commit Bot

Fixed memory leak in FileURLLoader/FileURLDirectoryLoader.

OnConnectionError should have been resetting both the data producer
as well as the client.

Bug: 958796
Change-Id: Ibc60dc05f7763e4ac61b43e445b5f2b40adc9246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733018Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#683745}
parent 459f0f89
...@@ -226,7 +226,9 @@ class FileURLDirectoryLoader ...@@ -226,7 +226,9 @@ class FileURLDirectoryLoader
} }
void OnConnectionError() { void OnConnectionError() {
data_producer_.reset();
binding_.Close(); binding_.Close();
client_.reset();
MaybeDeleteSelf(); MaybeDeleteSelf();
} }
...@@ -671,7 +673,9 @@ class FileURLLoader : public network::mojom::URLLoader { ...@@ -671,7 +673,9 @@ class FileURLLoader : public network::mojom::URLLoader {
} }
void OnConnectionError() { void OnConnectionError() {
data_producer_.reset();
binding_.Close(); binding_.Close();
client_.reset();
MaybeDeleteSelf(); MaybeDeleteSelf();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment