Commit 359bdf76 authored by Natalie Chouinard's avatar Natalie Chouinard Committed by Commit Bot

[Settings Refactor] Move autofill settings

Move autofill settings alongside autofill code.

Bug: 1047357
Change-Id: Id5679d4392e23cff775dfcefa41930af9ab0f602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031538Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737874}
parent 4abdf8ea
...@@ -2561,6 +2561,7 @@ generate_jni("chrome_jni_headers") { ...@@ -2561,6 +2561,7 @@ generate_jni("chrome_jni_headers") {
"java/src/org/chromium/chrome/browser/autofill/CreditCardScannerBridge.java", "java/src/org/chromium/chrome/browser/autofill/CreditCardScannerBridge.java",
"java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java", "java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java",
"java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java", "java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillProfileBridge.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTask.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTask.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskScheduler.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskScheduler.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncPwaDetector.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncPwaDetector.java",
...@@ -2775,7 +2776,6 @@ generate_jni("chrome_jni_headers") { ...@@ -2775,7 +2776,6 @@ generate_jni("chrome_jni_headers") {
"java/src/org/chromium/chrome/browser/send_tab_to_self/TargetDeviceInfo.java", "java/src/org/chromium/chrome/browser/send_tab_to_self/TargetDeviceInfo.java",
"java/src/org/chromium/chrome/browser/settings/NfcSystemLevelSetting.java", "java/src/org/chromium/chrome/browser/settings/NfcSystemLevelSetting.java",
"java/src/org/chromium/chrome/browser/settings/about/AboutSettingsBridge.java", "java/src/org/chromium/chrome/browser/settings/about/AboutSettingsBridge.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillProfileBridge.java",
"java/src/org/chromium/chrome/browser/settings/password/PasswordEditingBridge.java", "java/src/org/chromium/chrome/browser/settings/password/PasswordEditingBridge.java",
"java/src/org/chromium/chrome/browser/settings/password/PasswordUIView.java", "java/src/org/chromium/chrome/browser/settings/password/PasswordUIView.java",
"java/src/org/chromium/chrome/browser/settings/privacy/BrowsingDataBridge.java", "java/src/org/chromium/chrome/browser/settings/privacy/BrowsingDataBridge.java",
......
...@@ -102,6 +102,19 @@ chrome_java_sources = [ ...@@ -102,6 +102,19 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/autofill/prefeditor/ExpandableGridView.java", "java/src/org/chromium/chrome/browser/autofill/prefeditor/ExpandableGridView.java",
"java/src/org/chromium/chrome/browser/autofill/prefeditor/HintedDropDownAdapter.java", "java/src/org/chromium/chrome/browser/autofill/prefeditor/HintedDropDownAdapter.java",
"java/src/org/chromium/chrome/browser/autofill/prefeditor/HintedDropDownAdapterWithPlusIcon.java", "java/src/org/chromium/chrome/browser/autofill/prefeditor/HintedDropDownAdapterWithPlusIcon.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AndroidPaymentAppPreference.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AndroidPaymentAppsFragment.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillCreditCardEditor.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillEditLinkPreference.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillEditorBase.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillLocalCardEditor.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillPaymentMethodsFragment.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillProfileBridge.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillProfileEditorPreference.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillProfilesFragment.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillServerCardEditor.java",
"java/src/org/chromium/chrome/browser/autofill/settings/AutofillServerProfileFragment.java",
"java/src/org/chromium/chrome/browser/autofill/settings/CreditCardNumberFormattingTextWatcher.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTask.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTask.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskScheduler.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskScheduler.java",
"java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncPwaDetector.java", "java/src/org/chromium/chrome/browser/background_sync/BackgroundSyncPwaDetector.java",
...@@ -1375,19 +1388,6 @@ chrome_java_sources = [ ...@@ -1375,19 +1388,6 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/settings/about/LegalInformationSettings.java", "java/src/org/chromium/chrome/browser/settings/about/LegalInformationSettings.java",
"java/src/org/chromium/chrome/browser/settings/accessibility/AccessibilitySettings.java", "java/src/org/chromium/chrome/browser/settings/accessibility/AccessibilitySettings.java",
"java/src/org/chromium/chrome/browser/settings/accessibility/TextScalePreference.java", "java/src/org/chromium/chrome/browser/settings/accessibility/TextScalePreference.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AndroidPaymentAppPreference.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AndroidPaymentAppsFragment.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillCreditCardEditor.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillEditLinkPreference.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillEditorBase.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillLocalCardEditor.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillPaymentMethodsFragment.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillProfileBridge.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillProfileEditorPreference.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillProfilesFragment.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillServerCardEditor.java",
"java/src/org/chromium/chrome/browser/settings/autofill/AutofillServerProfileFragment.java",
"java/src/org/chromium/chrome/browser/settings/autofill/CreditCardNumberFormattingTextWatcher.java",
"java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionDataUseItem.java", "java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionDataUseItem.java",
"java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java", "java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java",
"java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionSiteBreakdownView.java", "java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionSiteBreakdownView.java",
......
...@@ -56,6 +56,8 @@ chrome_test_java_sources = [ ...@@ -56,6 +56,8 @@ chrome_test_java_sources = [
"javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java", "javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java",
"javatests/src/org/chromium/chrome/browser/autofill/AutofillUpstreamTest.java", "javatests/src/org/chromium/chrome/browser/autofill/AutofillUpstreamTest.java",
"javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java", "javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java",
"javatests/src/org/chromium/chrome/browser/autofill/settings/AutofillProfilesFragmentTest.java",
"javatests/src/org/chromium/chrome/browser/autofill/settings/AutofillTestRule.java",
"javatests/src/org/chromium/chrome/browser/background_sync/BackgroundSyncTest.java", "javatests/src/org/chromium/chrome/browser/background_sync/BackgroundSyncTest.java",
"javatests/src/org/chromium/chrome/browser/background_sync/PeriodicBackgroundSyncTest.java", "javatests/src/org/chromium/chrome/browser/background_sync/PeriodicBackgroundSyncTest.java",
"javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java", "javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java",
...@@ -409,8 +411,6 @@ chrome_test_java_sources = [ ...@@ -409,8 +411,6 @@ chrome_test_java_sources = [
"javatests/src/org/chromium/chrome/browser/settings/PasswordViewingTypeTest.java", "javatests/src/org/chromium/chrome/browser/settings/PasswordViewingTypeTest.java",
"javatests/src/org/chromium/chrome/browser/settings/SettingsActivityTest.java", "javatests/src/org/chromium/chrome/browser/settings/SettingsActivityTest.java",
"javatests/src/org/chromium/chrome/browser/settings/accessibility/AccessibilitySettingsTest.java", "javatests/src/org/chromium/chrome/browser/settings/accessibility/AccessibilitySettingsTest.java",
"javatests/src/org/chromium/chrome/browser/settings/autofill/AutofillProfilesFragmentTest.java",
"javatests/src/org/chromium/chrome/browser/settings/autofill/AutofillTestRule.java",
"javatests/src/org/chromium/chrome/browser/settings/datareduction/DataReductionStatsPreferenceTest.java", "javatests/src/org/chromium/chrome/browser/settings/datareduction/DataReductionStatsPreferenceTest.java",
"javatests/src/org/chromium/chrome/browser/settings/developer/TracingSettingsTest.java", "javatests/src/org/chromium/chrome/browser/settings/developer/TracingSettingsTest.java",
"javatests/src/org/chromium/chrome/browser/settings/notifications/NotificationsSettingsTest.java", "javatests/src/org/chromium/chrome/browser/settings/notifications/NotificationsSettingsTest.java",
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
android:key="server_profile_description" android:key="server_profile_description"
android:selectable="false" /> android:selectable="false" />
<org.chromium.chrome.browser.settings.autofill.AutofillEditLinkPreference <org.chromium.chrome.browser.autofill.settings.AutofillEditLinkPreference
android:key="server_profile_edit_link" /> android:key="server_profile_edit_link" />
</PreferenceScreen> </PreferenceScreen>
...@@ -36,12 +36,12 @@ ...@@ -36,12 +36,12 @@
android:order="5" android:order="5"
android:title="@string/password_settings_title"/> android:title="@string/password_settings_title"/>
<org.chromium.chrome.browser.settings.ChromeBasePreference <org.chromium.chrome.browser.settings.ChromeBasePreference
android:fragment="org.chromium.chrome.browser.settings.autofill.AutofillPaymentMethodsFragment" android:fragment="org.chromium.chrome.browser.autofill.settings.AutofillPaymentMethodsFragment"
android:key="autofill_payment_methods" android:key="autofill_payment_methods"
android:order="6" android:order="6"
android:title="@string/autofill_payment_methods"/> android:title="@string/autofill_payment_methods"/>
<org.chromium.chrome.browser.settings.ChromeBasePreference <org.chromium.chrome.browser.settings.ChromeBasePreference
android:fragment="org.chromium.chrome.browser.settings.autofill.AutofillProfilesFragment" android:fragment="org.chromium.chrome.browser.autofill.settings.AutofillProfilesFragment"
android:key="autofill_addresses" android:key="autofill_addresses"
android:order="7" android:order="7"
android:title="@string/autofill_addresses_settings_title"/> android:title="@string/autofill_addresses_settings_title"/>
......
...@@ -15,9 +15,9 @@ import org.chromium.base.annotations.JNINamespace; ...@@ -15,9 +15,9 @@ import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods; import org.chromium.base.annotations.NativeMethods;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ResourceId; import org.chromium.chrome.browser.ResourceId;
import org.chromium.chrome.browser.autofill.settings.AutofillEditorBase;
import org.chromium.chrome.browser.preferences.Pref; import org.chromium.chrome.browser.preferences.Pref;
import org.chromium.chrome.browser.preferences.PrefServiceBridge; import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.settings.autofill.AutofillEditorBase;
import org.chromium.content_public.browser.WebContents; import org.chromium.content_public.browser.WebContents;
import java.util.ArrayList; import java.util.ArrayList;
......
...@@ -42,10 +42,10 @@ import androidx.annotation.VisibleForTesting; ...@@ -42,10 +42,10 @@ import androidx.annotation.VisibleForTesting;
import org.chromium.base.ApiCompatibilityUtils; import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.settings.CreditCardNumberFormattingTextWatcher;
import org.chromium.chrome.browser.help.HelpAndFeedback; import org.chromium.chrome.browser.help.HelpAndFeedback;
import org.chromium.chrome.browser.profiles.Profile; import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.settings.SettingsUtils; import org.chromium.chrome.browser.settings.SettingsUtils;
import org.chromium.chrome.browser.settings.autofill.CreditCardNumberFormattingTextWatcher;
import org.chromium.components.browser_ui.widget.AlwaysDismissedDialog; import org.chromium.components.browser_ui.widget.AlwaysDismissedDialog;
import org.chromium.components.browser_ui.widget.FadingEdgeScrollView; import org.chromium.components.browser_ui.widget.FadingEdgeScrollView;
import org.chromium.components.browser_ui.widget.TintedDrawable; import org.chromium.components.browser_ui.widget.TintedDrawable;
......
...@@ -25,7 +25,7 @@ import androidx.annotation.VisibleForTesting; ...@@ -25,7 +25,7 @@ import androidx.annotation.VisibleForTesting;
import org.chromium.base.ApiCompatibilityUtils; import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge.DropdownKeyValue; import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge.DropdownKeyValue;
import org.chromium.ui.KeyboardVisibilityDelegate; import org.chromium.ui.KeyboardVisibilityDelegate;
import java.util.ArrayList; import java.util.ArrayList;
......
...@@ -12,7 +12,7 @@ import androidx.annotation.Nullable; ...@@ -12,7 +12,7 @@ import androidx.annotation.Nullable;
import org.chromium.base.Callback; import org.chromium.base.Callback;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge.DropdownKeyValue; import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge.DropdownKeyValue;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.support.v7.preference.Preference; import android.support.v7.preference.Preference;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.graphics.Bitmap; import android.graphics.Bitmap;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.os.Build; import android.os.Build;
import android.os.Bundle; import android.os.Bundle;
...@@ -29,8 +29,8 @@ abstract class AutofillCreditCardEditor extends AutofillEditorBase { ...@@ -29,8 +29,8 @@ abstract class AutofillCreditCardEditor extends AutofillEditorBase {
protected int mInitialBillingAddressPos; protected int mInitialBillingAddressPos;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, public View onCreateView(
Bundle savedInstanceState) { LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
View v = super.onCreateView(inflater, container, savedInstanceState); View v = super.onCreateView(inflater, container, savedInstanceState);
// Do not use autofill for the fields. // Do not use autofill for the fields.
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.support.v7.preference.Preference; import android.support.v7.preference.Preference;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.annotation.SuppressLint; import android.annotation.SuppressLint;
import android.content.Context; import android.content.Context;
...@@ -49,8 +49,8 @@ public abstract class AutofillEditorBase ...@@ -49,8 +49,8 @@ public abstract class AutofillEditorBase
protected Context mContext; protected Context mContext;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, public View onCreateView(
Bundle savedInstanceState) { LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
super.onCreateView(inflater, container, savedInstanceState); super.onCreateView(inflater, container, savedInstanceState);
setHasOptionsMenu(true); setHasOptionsMenu(true);
mContext = container.getContext(); mContext = container.getContext();
...@@ -129,21 +129,21 @@ public abstract class AutofillEditorBase ...@@ -129,21 +129,21 @@ public abstract class AutofillEditorBase
protected void initializeButtons(View layout) { protected void initializeButtons(View layout) {
Button button = (Button) layout.findViewById(R.id.button_secondary); Button button = (Button) layout.findViewById(R.id.button_secondary);
button.setOnClickListener(new View.OnClickListener() { button.setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
getActivity().finish(); getActivity().finish();
} }
}); });
button = (Button) layout.findViewById(R.id.button_primary); button = (Button) layout.findViewById(R.id.button_primary);
button.setOnClickListener(new View.OnClickListener() { button.setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
if (saveEntry()) { if (saveEntry()) {
getActivity().finish(); getActivity().finish();
}
} }
}); }
});
button.setEnabled(false); button.setEnabled(false);
} }
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.os.Bundle; import android.os.Bundle;
import android.text.Editable; import android.text.Editable;
...@@ -49,8 +49,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor { ...@@ -49,8 +49,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor {
public AutofillLocalCardEditor() {} public AutofillLocalCardEditor() {}
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, public View onCreateView(
Bundle savedInstanceState) { LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
// Allow screenshots of the credit card number in Canary, Dev, and developer builds. // Allow screenshots of the credit card number in Canary, Dev, and developer builds.
if (ChromeVersionInfo.isBetaBuild() || ChromeVersionInfo.isStableBuild()) { if (ChromeVersionInfo.isBetaBuild() || ChromeVersionInfo.isStableBuild()) {
WindowManager.LayoutParams attributes = getActivity().getWindow().getAttributes(); WindowManager.LayoutParams attributes = getActivity().getWindow().getAttributes();
...@@ -84,8 +84,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor { ...@@ -84,8 +84,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor {
@Override @Override
protected int getTitleResourceId(boolean isNewEntry) { protected int getTitleResourceId(boolean isNewEntry) {
return isNewEntry return isNewEntry ? R.string.autofill_create_credit_card
? R.string.autofill_create_credit_card : R.string.autofill_edit_credit_card; : R.string.autofill_edit_credit_card;
} }
@Override @Override
...@@ -103,8 +103,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor { ...@@ -103,8 +103,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor {
} }
void addSpinnerAdapters() { void addSpinnerAdapters() {
ArrayAdapter<CharSequence> adapter = new ArrayAdapter<CharSequence>(getActivity(), ArrayAdapter<CharSequence> adapter =
android.R.layout.simple_spinner_item); new ArrayAdapter<CharSequence>(getActivity(), android.R.layout.simple_spinner_item);
// Populate the month dropdown. // Populate the month dropdown.
Calendar calendar = Calendar.getInstance(); Calendar calendar = Calendar.getInstance();
...@@ -119,8 +119,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor { ...@@ -119,8 +119,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor {
mExpirationMonth.setAdapter(adapter); mExpirationMonth.setAdapter(adapter);
// Populate the year dropdown. // Populate the year dropdown.
adapter = new ArrayAdapter<CharSequence>(getActivity(), adapter =
android.R.layout.simple_spinner_item); new ArrayAdapter<CharSequence>(getActivity(), android.R.layout.simple_spinner_item);
int initialYear = calendar.get(Calendar.YEAR); int initialYear = calendar.get(Calendar.YEAR);
for (int year = initialYear; year < initialYear + 10; year++) { for (int year = initialYear; year < initialYear + 10; year++) {
adapter.add(Integer.toString(year)); adapter.add(Integer.toString(year));
...@@ -181,8 +181,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor { ...@@ -181,8 +181,8 @@ public class AutofillLocalCardEditor extends AutofillCreditCardEditor {
// Issuer network will be empty if credit card number is not valid. // Issuer network will be empty if credit card number is not valid.
if (TextUtils.isEmpty(personalDataManager.getBasicCardIssuerNetwork( if (TextUtils.isEmpty(personalDataManager.getBasicCardIssuerNetwork(
cardNumber, true /* emptyIfInvalid */))) { cardNumber, true /* emptyIfInvalid */))) {
mNumberLabel.setError(mContext.getString( mNumberLabel.setError(
R.string.payments_card_number_invalid_validation_message)); mContext.getString(R.string.payments_card_number_invalid_validation_message));
return false; return false;
} }
CreditCard card = personalDataManager.getCreditCardForNumber(cardNumber); CreditCard card = personalDataManager.getCreditCardForNumber(cardNumber);
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.graphics.PorterDuff; import android.graphics.PorterDuff;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.app.Activity; import android.app.Activity;
import android.support.v4.app.Fragment; import android.support.v4.app.Fragment;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.support.v7.preference.DialogPreference; import android.support.v7.preference.DialogPreference;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.graphics.PorterDuff; import android.graphics.PorterDuff;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.os.Bundle; import android.os.Bundle;
import android.view.LayoutInflater; import android.view.LayoutInflater;
...@@ -31,8 +31,8 @@ public class AutofillServerCardEditor extends AutofillCreditCardEditor { ...@@ -31,8 +31,8 @@ public class AutofillServerCardEditor extends AutofillCreditCardEditor {
public AutofillServerCardEditor() {} public AutofillServerCardEditor() {}
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, public View onCreateView(
Bundle savedInstanceState) { LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
final View v = super.onCreateView(inflater, container, savedInstanceState); final View v = super.onCreateView(inflater, container, savedInstanceState);
if (mCard == null) { if (mCard == null) {
getActivity().finish(); getActivity().finish();
...@@ -40,8 +40,8 @@ public class AutofillServerCardEditor extends AutofillCreditCardEditor { ...@@ -40,8 +40,8 @@ public class AutofillServerCardEditor extends AutofillCreditCardEditor {
} }
((TextView) v.findViewById(R.id.title)).setText(mCard.getObfuscatedNumber()); ((TextView) v.findViewById(R.id.title)).setText(mCard.getObfuscatedNumber());
((TextView) v.findViewById(R.id.summary)).setText(mCard.getFormattedExpirationDate( ((TextView) v.findViewById(R.id.summary))
getActivity())); .setText(mCard.getFormattedExpirationDate(getActivity()));
v.findViewById(R.id.edit_server_card).setOnClickListener(new View.OnClickListener() { v.findViewById(R.id.edit_server_card).setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
...@@ -50,7 +50,6 @@ public class AutofillServerCardEditor extends AutofillCreditCardEditor { ...@@ -50,7 +50,6 @@ public class AutofillServerCardEditor extends AutofillCreditCardEditor {
} }
}); });
mLocalCopyLabel = v.findViewById(R.id.local_copy_label); mLocalCopyLabel = v.findViewById(R.id.local_copy_label);
mClearLocalCopy = v.findViewById(R.id.clear_local_copy); mClearLocalCopy = v.findViewById(R.id.clear_local_copy);
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.content.Context; import android.content.Context;
import android.os.Bundle; import android.os.Bundle;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.text.Editable; import android.text.Editable;
import android.text.TextUtils; import android.text.TextUtils;
...@@ -110,8 +110,7 @@ public class CreditCardNumberFormattingTextWatcher implements TextWatcher { ...@@ -110,8 +110,7 @@ public class CreditCardNumberFormattingTextWatcher implements TextWatcher {
} }
} }
public static boolean hasDashOrSpace(final CharSequence s, final int start, public static boolean hasDashOrSpace(final CharSequence s, final int start, final int count) {
final int count) {
return TextUtils.indexOf(s, " ", start, start + count) != -1 return TextUtils.indexOf(s, " ", start, start + count) != -1
|| TextUtils.indexOf(s, "-", start, start + count) != -1; || TextUtils.indexOf(s, "-", start, start + count) != -1;
} }
......
...@@ -22,10 +22,10 @@ import org.chromium.chrome.browser.autofill.prefeditor.EditorBase; ...@@ -22,10 +22,10 @@ import org.chromium.chrome.browser.autofill.prefeditor.EditorBase;
import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel; import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel;
import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel.EditorFieldValidator; import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel.EditorFieldValidator;
import org.chromium.chrome.browser.autofill.prefeditor.EditorModel; import org.chromium.chrome.browser.autofill.prefeditor.EditorModel;
import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge;
import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge.AddressField;
import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge.AddressUiComponent;
import org.chromium.chrome.browser.flags.ChromeFeatureList; import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge.AddressField;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge.AddressUiComponent;
import org.chromium.payments.mojom.AddressErrors; import org.chromium.payments.mojom.AddressErrors;
import java.lang.annotation.Retention; import java.lang.annotation.Retention;
......
...@@ -17,8 +17,8 @@ import org.chromium.chrome.R; ...@@ -17,8 +17,8 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.PersonalDataManager; import org.chromium.chrome.browser.autofill.PersonalDataManager;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile; import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
import org.chromium.chrome.browser.autofill.prefeditor.EditableOption; import org.chromium.chrome.browser.autofill.prefeditor.EditableOption;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge; import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge.AddressField; import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge.AddressField;
import org.chromium.payments.mojom.PaymentAddress; import org.chromium.payments.mojom.PaymentAddress;
import java.lang.annotation.Retention; import java.lang.annotation.Retention;
......
...@@ -28,8 +28,8 @@ import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel; ...@@ -28,8 +28,8 @@ import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel;
import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel.EditorFieldValidator; import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel.EditorFieldValidator;
import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel.EditorValueIconGenerator; import org.chromium.chrome.browser.autofill.prefeditor.EditorFieldModel.EditorValueIconGenerator;
import org.chromium.chrome.browser.autofill.prefeditor.EditorModel; import org.chromium.chrome.browser.autofill.prefeditor.EditorModel;
import org.chromium.chrome.browser.autofill.settings.AutofillProfileBridge.DropdownKeyValue;
import org.chromium.chrome.browser.payments.PaymentRequestImpl.PaymentRequestServiceObserverForTest; import org.chromium.chrome.browser.payments.PaymentRequestImpl.PaymentRequestServiceObserverForTest;
import org.chromium.chrome.browser.settings.autofill.AutofillProfileBridge.DropdownKeyValue;
import org.chromium.components.payments.MethodStrings; import org.chromium.components.payments.MethodStrings;
import org.chromium.content_public.browser.WebContents; import org.chromium.content_public.browser.WebContents;
import org.chromium.payments.mojom.PaymentMethodData; import org.chromium.payments.mojom.PaymentMethodData;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.support.test.InstrumentationRegistry; import android.support.test.InstrumentationRegistry;
import android.support.test.filters.MediumTest; import android.support.test.filters.MediumTest;
...@@ -123,8 +123,8 @@ public class AutofillProfilesFragmentTest { ...@@ -123,8 +123,8 @@ public class AutofillProfilesFragmentTest {
Assert.assertNotNull(addProfile); Assert.assertNotNull(addProfile);
// Try to add an incomplete profile. // Try to add an incomplete profile.
updatePreferencesAndWait(autofillProfileFragment, addProfile, updatePreferencesAndWait(autofillProfileFragment, addProfile, new String[] {"Mike Doe"},
new String[] {"Mike Doe"}, R.id.editor_dialog_done_button, true); R.id.editor_dialog_done_button, true);
activity.finish(); activity.finish();
} }
...@@ -148,8 +148,8 @@ public class AutofillProfilesFragmentTest { ...@@ -148,8 +148,8 @@ public class AutofillProfilesFragmentTest {
Assert.assertEquals("Seb Doe", sebProfile.getTitle()); Assert.assertEquals("Seb Doe", sebProfile.getTitle());
// Delete a profile. // Delete a profile.
updatePreferencesAndWait(autofillProfileFragment, sebProfile, null, updatePreferencesAndWait(
R.id.delete_menu_id, false); autofillProfileFragment, sebProfile, null, R.id.delete_menu_id, false);
Assert.assertEquals(5 /* One toggle + one add button + three profile. */, Assert.assertEquals(5 /* One toggle + one add button + three profile. */,
autofillProfileFragment.getPreferenceScreen().getPreferenceCount()); autofillProfileFragment.getPreferenceScreen().getPreferenceCount());
...@@ -226,8 +226,8 @@ public class AutofillProfilesFragmentTest { ...@@ -226,8 +226,8 @@ public class AutofillProfilesFragmentTest {
Assert.assertEquals("Bob Doe", bobProfile.getTitle()); Assert.assertEquals("Bob Doe", bobProfile.getTitle());
// Open the profile. // Open the profile.
updatePreferencesAndWait(autofillProfileFragment, bobProfile, null, updatePreferencesAndWait(
R.id.editor_dialog_done_button, false); autofillProfileFragment, bobProfile, null, R.id.editor_dialog_done_button, false);
Assert.assertEquals(6 /* One toggle + one add button + four profiles. */, Assert.assertEquals(6 /* One toggle + one add button + four profiles. */,
autofillProfileFragment.getPreferenceScreen().getPreferenceCount()); autofillProfileFragment.getPreferenceScreen().getPreferenceCount());
...@@ -254,8 +254,8 @@ public class AutofillProfilesFragmentTest { ...@@ -254,8 +254,8 @@ public class AutofillProfilesFragmentTest {
Assert.assertEquals("Bill Doe", billProfile.getTitle()); Assert.assertEquals("Bill Doe", billProfile.getTitle());
// Open the profile. // Open the profile.
updatePreferencesAndWait(autofillProfileFragment, billProfile, null, updatePreferencesAndWait(
R.id.editor_dialog_done_button, false); autofillProfileFragment, billProfile, null, R.id.editor_dialog_done_button, false);
// Check if the preferences are updated correctly. // Check if the preferences are updated correctly.
Assert.assertEquals(6 /* One toggle + one add button + four profiles. */, Assert.assertEquals(6 /* One toggle + one add button + four profiles. */,
...@@ -310,7 +310,7 @@ public class AutofillProfilesFragmentTest { ...@@ -310,7 +310,7 @@ public class AutofillProfilesFragmentTest {
public boolean isSatisfied() { public boolean isSatisfied() {
return keyboardVisible return keyboardVisible
== KeyboardVisibilityDelegate.getInstance().isKeyboardShowing( == KeyboardVisibilityDelegate.getInstance().isKeyboardShowing(
activity, activity.findViewById(android.R.id.content)); activity, activity.findViewById(android.R.id.content));
} }
}); });
} }
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.settings.autofill; package org.chromium.chrome.browser.autofill.settings;
import android.view.KeyEvent; import android.view.KeyEvent;
import android.widget.EditText; import android.widget.EditText;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment