Download later: Adjust radio buttons left padding.

Radio button left padding for download later dialog needs to match the
title text and the checkbox. Also pull the common value to dimens.xml.

Bug: 1078454
Change-Id: If2261ce28cd22d55cd09aa5ed32786896b531358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306752Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790031}

chrome/browser/download/android/java/res/layout/download_later_dialog.xml

@@ -37,27 +37,26 @@
             android:layout_width="match_parent"
             android:layout_height="match_parent">
 
-            <!-- TODO(xingliu): Use 0 paddingStart for RadioButtonWithDescription. See crbug.com/1090062 -->
             <!-- TODO(xingliu): Adjust margin between RadioButtonWithDescription. See crbug.com/1090155 -->
             <org.chromium.components.browser_ui.widget.RadioButtonWithDescription
                 android:id="@+id/download_now"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:paddingStart="1dp"
+                android:paddingStart="@dimen/download_dialog_radio_button_margin_start"
                 app:primaryText="@string/download_later_download_now_text" />
 
             <org.chromium.components.browser_ui.widget.RadioButtonWithDescription
                 android:id="@+id/on_wifi"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:paddingStart="1dp"
+                android:paddingStart="@dimen/download_dialog_radio_button_margin_start"
                 app:primaryText="@string/download_later_on_wifi_text" />
 
             <org.chromium.components.browser_ui.widget.RadioButtonWithDescription
                 android:id="@+id/choose_date_time"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:paddingStart="1dp"
+                android:paddingStart="@dimen/download_dialog_radio_button_margin_start"
                 app:primaryText="@string/download_later_pick_time_text" />
 
         </org.chromium.components.browser_ui.widget.RadioButtonWithDescriptionLayout>
@@ -68,7 +67,7 @@
             android:layout_height="wrap_content"
             android:layout_marginTop="11dp"
             android:layout_marginBottom="11dp"
-            android:layout_marginStart="-5dp"
+            android:layout_marginStart="@dimen/download_dialog_checkbox_margin_start"
             android:text="@string/download_location_dialog_checkbox"
             style="@style/TextAppearance.TextMedium.Tertiary"
             android:visibility="gone" />

chrome/browser/download/android/java/res/layout/download_location_dialog.xml

@@ -77,7 +77,7 @@
             android:layout_height="wrap_content"
             android:text="@string/download_location_dialog_checkbox"
             android:layout_marginTop="16dp"
-            android:layout_marginStart="-5dp"/>
+            android:layout_marginStart="@dimen/download_dialog_checkbox_margin_start"/>
 
     </LinearLayout>
 

chrome/browser/download/android/java/res/values-v17/dimens.xml

@@ -6,4 +6,6 @@
 <resources xmlns:tools="http://schemas.android.com/tools">
     <dimen name="download_dialog_title_margin_bottom">3dp</dimen>
     <dimen name="download_dialog_subtitle_margin_bottom">10dp</dimen>
+    <dimen name="download_dialog_radio_button_margin_start">-5dp</dimen>
+    <dimen name="download_dialog_checkbox_margin_start">-5dp</dimen>
 </resources>