DevTools: do not kill breakpoints in case of persistence and auto-reconnecting target.
The investigation revealed: - BreakpointManager does not know how to set breakpoints in the UISourceCodes with exact URLs. For this reason, breakpoints are removed inside workers in case of multilpe workers launched with the same URL. - node.js reports file URLs which clash with the file URLs from persistence. This provokes the same illicit behavior in BreakpointManager. - the same would happen with file-url web sites with persistence folder This behavior is a conceptual issue of BreakpointManager, which is relied upon in different parts of BreakpointManager. Given the poor state of the things in the BreakpointManager, this patch suggests a trade-off solution for the issue: - it is localized to persistence only - it is localized to the case of URL collisition between FileSystem and network URLs Unfortunately, the attempts to write a test with workers failed due to the BreakpointManager's poor handling of breakpoints in workers. BUG=722636 R=dgozman Review-Url: https://codereview.chromium.org/2886643002 Cr-Commit-Position: refs/heads/master@{#472196}
Showing
Please register or sign in to comment