Commit 35ddac44 authored by Matt Mueller's avatar Matt Mueller Committed by Commit Bot

Some x509_certificate.h documentation fixes.

Remove reference to non-existant AddIntermediateCertificate method.

Clarify Equals documentation regarding intermediates.

Fix typo.

Bug: 751298
Change-Id: I630fd51176cc9de7e14a5917ab77f9a60a81f1e5
Reviewed-on: https://chromium-review.googlesource.com/596724Reviewed-by: default avatarDavid Benjamin <davidben@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491255}
parent d450cb9e
...@@ -221,9 +221,11 @@ class NET_EXPORT X509Certificate ...@@ -221,9 +221,11 @@ class NET_EXPORT X509Certificate
bool HasExpired() const; bool HasExpired() const;
// Returns true if this object and |other| represent the same certificate. // Returns true if this object and |other| represent the same certificate.
// Does not consider any associated intermediates.
bool Equals(const X509Certificate* other) const; bool Equals(const X509Certificate* other) const;
// Returns intermediate certificates added via AddIntermediateCertificate(). // Returns the associated intermediate certificates that were specified
// during creation of this object, if any.
// Ownership follows the "get" rule: it is the caller's responsibility to // Ownership follows the "get" rule: it is the caller's responsibility to
// retain the elements of the result. // retain the elements of the result.
const OSCertHandles& GetIntermediateCertificates() const { const OSCertHandles& GetIntermediateCertificates() const {
...@@ -262,7 +264,7 @@ class NET_EXPORT X509Certificate ...@@ -262,7 +264,7 @@ class NET_EXPORT X509Certificate
// Encodes the entire certificate chain (this certificate and any // Encodes the entire certificate chain (this certificate and any
// intermediate certificates stored in |intermediate_ca_certs_|) as a series // intermediate certificates stored in |intermediate_ca_certs_|) as a series
// of PEM encoded strings. Returns true if all certificates were encoded, // of PEM encoded strings. Returns true if all certificates were encoded,
// storig the result in |*pem_encoded|, with this certificate stored as // storing the result in |*pem_encoded|, with this certificate stored as
// the first element. // the first element.
bool GetPEMEncodedChain(std::vector<std::string>* pem_encoded) const; bool GetPEMEncodedChain(std::vector<std::string>* pem_encoded) const;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment