Stop Running Firewall Checks for MediaRouterMojoExtensionTest

The firewall checks weren't running before, and with the upcoming COM
initialization change for TestBrowserThreadBundle, they'll suddenly
start running, changing all of the assumptions for the
MediaRouterMojoExtensionTest.

This change disables firewall checking for tests.

BUG=735725

Change-Id: I6e6760ab42cf9d5180cfa33028fb3fb973a45f1f
Reviewed-on: https://chromium-review.googlesource.com/544900Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481741}

chrome/browser/media/router/mojo/media_router_mojo_impl.cc

@@ -62,7 +62,8 @@ MediaRouterMojoImpl::MediaSinksQuery::~MediaSinksQuery() = default;
 
 MediaRouterMojoImpl::MediaRouterMojoImpl(
     extensions::EventPageTracker* event_page_tracker,
-    content::BrowserContext* context)
+    content::BrowserContext* context,
+    FirewallCheck check_firewall)
     : event_page_tracker_(event_page_tracker),
       instance_id_(base::GenerateGUID()),
       availability_(mojom::MediaRouter::SinkAvailability::UNAVAILABLE),
@@ -72,9 +73,11 @@ MediaRouterMojoImpl::MediaRouterMojoImpl(
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK(event_page_tracker_);
 #if defined(OS_WIN)
-  CanFirewallUseLocalPorts(
-      base::Bind(&MediaRouterMojoImpl::OnFirewallCheckComplete,
-                 weak_factory_.GetWeakPtr()));
+  if (check_firewall == FirewallCheck::RUN) {
+    CanFirewallUseLocalPorts(
+        base::Bind(&MediaRouterMojoImpl::OnFirewallCheckComplete,
+                   weak_factory_.GetWeakPtr()));
+  }
 #endif
 }
 

chrome/browser/media/router/mojo/media_router_mojo_impl.h

@@ -211,10 +211,19 @@ class MediaRouterMojoImpl : public MediaRouterBase,
     DISALLOW_COPY_AND_ASSIGN(MediaRoutesQuery);
   };
 
+  enum class FirewallCheck {
+    // Skips the firewall check for the benefit of unit tests so they do not
+    // have to depend on the system's firewall configuration.
+    SKIP_FOR_TESTING,
+    // Perform the firewall check (default).
+    RUN,
+  };
+
   // Standard constructor, used by
   // MediaRouterMojoImplFactory::GetApiForBrowserContext.
   MediaRouterMojoImpl(extensions::EventPageTracker* event_page_tracker,
-                      content::BrowserContext* context);
+                      content::BrowserContext* context,
+                      FirewallCheck check_firewall = FirewallCheck::RUN);
 
   // Binds |this| to a Mojo interface request, so that clients can acquire a
   // handle to a MediaRouterMojoImpl instance via the Mojo service connector.

chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

@@ -1427,8 +1427,9 @@ class MediaRouterMojoExtensionTest : public ::testing::Test {
     DCHECK(process_manager_);
 
     // Create MR and its proxy, so that it can be accessed through Mojo.
-    media_router_.reset(
-        new MediaRouterMojoImpl(process_manager_, profile_.get()));
+    media_router_.reset(new MediaRouterMojoImpl(
+        process_manager_, profile_.get(),
+        MediaRouterMojoImpl::FirewallCheck::SKIP_FOR_TESTING));
     ProcessEventLoop();
   }
 
@@ -1570,6 +1571,7 @@ TEST_F(MediaRouterMojoExtensionTest, AttemptedWakeupTooManyTimes) {
       .WillOnce(Return(true));
   EXPECT_CALL(*process_manager_, WakeEventPage(extension_->id(), _))
       .WillOnce(testing::DoAll(media::RunCallback<1>(true), Return(true)));
+  ASSERT_TRUE(media_router_->pending_requests_.empty());
   media_router_->DetachRoute(kRouteId);
   EXPECT_EQ(1u, media_router_->pending_requests_.size());
   ExpectWakeReasonBucketCount(MediaRouteProviderWakeReason::DETACH_ROUTE, 1);