WebUI Tab Strip: Add event for when a tab is replaced

Bug: 989131
Change-Id: I08b4da7bf37dcd0353f3553844ef7c9e8bf1cf14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900659
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714072}

chrome/browser/resources/tab_strip/tab_list.js

@@ -170,6 +170,8 @@ class TabListElement extends CustomElement {
       addWebUIListener(
           'tab-moved', (tabId, newIndex) => this.onTabMoved_(tabId, newIndex));
       addWebUIListener('tab-removed', tabId => this.onTabRemoved_(tabId));
+      addWebUIListener(
+          'tab-replaced', (oldId, newId) => this.onTabReplaced_(oldId, newId));
       addWebUIListener('tab-updated', tab => this.onTabUpdated_(tab));
       addWebUIListener(
           'tab-active-changed', tabId => this.onTabActivated_(tabId));
@@ -413,6 +415,21 @@ class TabListElement extends CustomElement {
     }
   }
 
+  /**
+   * @param {number} oldId
+   * @param {number} newId
+   * @private
+   */
+  onTabReplaced_(oldId, newId) {
+    const tabElement = this.findTabElement_(oldId);
+    if (!tabElement) {
+      return;
+    }
+
+    tabElement.tab = /** @type {!TabData} */ (
+        Object.assign({}, tabElement.tab, {id: newId}));
+  }
+
   /**
    * @param {!TabData} tab
    * @private

chrome/browser/ui/webui/tab_strip/tab_strip_ui.cc

@@ -171,11 +171,21 @@ class TabStripUIHandler : public content::WebUIMessageHandler,
             base::Value(move->to_index));
         break;
       }
-
-      case TabStripModelChange::kReplaced:
-      case TabStripModelChange::kGroupChanged:
+      case TabStripModelChange::kReplaced: {
+        auto* replace = change.GetReplace();
+        FireWebUIListener("tab-replaced",
+                          base::Value(extensions::ExtensionTabUtil::GetTabId(
+                              replace->old_contents)),
+                          base::Value(extensions::ExtensionTabUtil::GetTabId(
+                              replace->new_contents)));
+        break;
+      }
+      case TabStripModelChange::kGroupChanged: {
+        // Not yet implmented.
+        break;
+      }
       case TabStripModelChange::kSelectionOnly:
-        // Not yet implemented.
+        // Multi-selection is not supported for touch.
         break;
     }
 

chrome/test/data/webui/tab_strip/tab_list_test.js

@@ -522,4 +522,10 @@ suite('TabList', () => {
         window.dispatchEvent(new Event('blur'));
         assertEquals(tabList.shadowRoot.activeElement, null);
       });
+
+  test('should update the ID when a tab is replaced', () => {
+    assertEquals(getUnpinnedTabs()[0].tab.id, 0);
+    webUIListenerCallback('tab-replaced', tabs[0].id, 1000);
+    assertEquals(getUnpinnedTabs()[0].tab.id, 1000);
+  });
 });