Commit 362f86ca authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

sheriff: disable one MachineLevelUserCloudPolicyRobotAuthTest

This also requires undefining an earlier MAYBE_ macro, which is kind of
icky. These tests should have more distinctive names.

Bug: 1105167
Change-Id: Idf608d94fabd5ea8de7808007a08fbfe0ba8592c
Tbr: anthonyvd@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346976Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796921}
parent 056cfb22
...@@ -535,6 +535,7 @@ class ChromeBrowserCloudManagementEnrollmentTest ...@@ -535,6 +535,7 @@ class ChromeBrowserCloudManagementEnrollmentTest
#define MAYBE_Test Test #define MAYBE_Test Test
#endif #endif
IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementEnrollmentTest, MAYBE_Test) { IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementEnrollmentTest, MAYBE_Test) {
#undef MAYBE_Test
// Test body is run only if enrollment is succeeded or failed without error // Test body is run only if enrollment is succeeded or failed without error
// message. // message.
EXPECT_TRUE(is_enrollment_token_valid() || !should_display_error_message()); EXPECT_TRUE(is_enrollment_token_valid() || !should_display_error_message());
...@@ -789,7 +790,13 @@ class MachineLevelUserCloudPolicyRobotAuthTest ...@@ -789,7 +790,13 @@ class MachineLevelUserCloudPolicyRobotAuthTest
network::TestURLLoaderFactory test_url_loader_factory_; network::TestURLLoaderFactory test_url_loader_factory_;
}; // namespace policy }; // namespace policy
IN_PROC_BROWSER_TEST_F(MachineLevelUserCloudPolicyRobotAuthTest, Test) { // Flaky on linux & win: https://crbug.com/1105167
#if defined(OS_WIN) || defined(OS_LINUX)
#define MAYBE_Test DISABLED_Test
#else
#define MAYBE_Test Test
#endif
IN_PROC_BROWSER_TEST_F(MachineLevelUserCloudPolicyRobotAuthTest, MAYBE_Test) {
MachineLevelUserCloudPolicyManager* manager = MachineLevelUserCloudPolicyManager* manager =
g_browser_process->browser_policy_connector() g_browser_process->browser_policy_connector()
->machine_level_user_cloud_policy_manager(); ->machine_level_user_cloud_policy_manager();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment