Move page_load_metrics renderer to components

This patch moves chrome/renderer/page_load_metrics to
components/page_load_metrics/renderer, and is mostly
moving the file, no feature change.

OWNER file has been move to components/page_load_metrics,
is changed to same as chrome/browser/page_load_metrics/OWNERS
components/page_load_metrics/common/OWNERS is deleted.

Bug: 995880
Change-Id: Idbd70e7dda295db2cacb0bdcad1c5ba13fb48fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773919
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691956}

chrome/renderer/BUILD.gn

@@ -73,13 +73,6 @@ jumbo_static_library("renderer") {
     "net/net_error_page_controller.h",
     "net_benchmarking_extension.cc",
     "net_benchmarking_extension.h",
-    "page_load_metrics/metrics_render_frame_observer.cc",
-    "page_load_metrics/metrics_render_frame_observer.h",
-    "page_load_metrics/page_resource_data_use.cc",
-    "page_load_metrics/page_resource_data_use.h",
-    "page_load_metrics/page_timing_metrics_sender.cc",
-    "page_load_metrics/page_timing_metrics_sender.h",
-    "page_load_metrics/page_timing_sender.h",
     "plugins/non_loadable_plugin_placeholder.cc",
     "plugins/non_loadable_plugin_placeholder.h",
     "plugins/pdf_plugin_placeholder.cc",
@@ -144,6 +137,7 @@ jumbo_static_library("renderer") {
     "//components/network_hints/renderer",
     "//components/omnibox/common",
     "//components/page_image_annotation/content/renderer",
+    "//components/page_load_metrics/renderer",
     "//components/plugins/renderer",
     "//components/rappor/public/mojom",
     "//components/resources:components_resources",

chrome/renderer/DEPS

@@ -25,6 +25,7 @@ include_rules = [
   "+components/network_session_configurator/common",
   "+components/offline_pages/buildflags",
   "+components/page_load_metrics/common",
+  "+components/page_load_metrics/renderer",
   "+components/password_manager/content/renderer",
   "+components/password_manager/core/common",
   "+components/pdf/renderer",

chrome/renderer/OWNERS

@@ -3,7 +3,7 @@
 per-file BUILD.gn=*
 
 # Page Load Histogram files.
-per-file loadtimes_extension_bindings*=file://chrome/renderer/page_load_metrics/OWNERS
+per-file loadtimes_extension_bindings*=file://components/page_load_metrics/OWNERS
 # Instant/Search files.
 per-file instant_restricted_id_cache*=file://chrome/browser/search/OWNERS
 

chrome/renderer/chrome_content_renderer_client.cc

@@ -52,7 +52,6 @@
 #include "chrome/renderer/media/webrtc_logging_agent_impl.h"
 #include "chrome/renderer/net/net_error_helper.h"
 #include "chrome/renderer/net_benchmarking_extension.h"
-#include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 #include "chrome/renderer/pepper/pepper_helper.h"
 #include "chrome/renderer/plugins/non_loadable_plugin_placeholder.h"
 #include "chrome/renderer/plugins/pdf_plugin_placeholder.h"
@@ -83,6 +82,7 @@
 #include "components/error_page/common/error.h"
 #include "components/error_page/common/localized_error.h"
 #include "components/network_hints/renderer/prescient_networking_dispatcher.h"
+#include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
 #include "components/pdf/renderer/pepper_pdf_host.h"
 #include "components/safe_browsing/buildflags.h"
 #include "components/safe_browsing/renderer/threat_dom_details.h"

chrome/renderer/page_load_metrics/OWNERS

-file://chrome/browser/page_load_metrics/OWNERS
-# COMPONENT: Speed>Metrics

chrome/test/BUILD.gn

@@ -3267,10 +3267,6 @@ test("unit_tests") {
     "../renderer/media/chrome_key_systems_provider_unittest.cc",
     "../renderer/media/flash_embed_rewrite_unittest.cc",
     "../renderer/net/net_error_helper_core_unittest.cc",
-    "../renderer/page_load_metrics/fake_page_timing_sender.cc",
-    "../renderer/page_load_metrics/fake_page_timing_sender.h",
-    "../renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc",
-    "../renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc",
     "../renderer/plugins/plugin_uma_unittest.cc",
     "../renderer/prerender/prerender_dispatcher_unittest.cc",
     "../renderer/subresource_redirect/subresource_redirect_experiments_unittest.cc",

components/BUILD.gn

@@ -239,6 +239,7 @@ test("components_unittests") {
       "//components/optimization_guide:unit_tests",
       "//components/page_image_annotation/content/renderer:unit_tests",
       "//components/page_image_annotation/core:unit_tests",
+      "//components/page_load_metrics/renderer:unit_tests",
       "//components/password_manager/content/browser:unit_tests",
       "//components/payments/content:unit_tests",
       "//components/payments/content/utility:unit_tests",

components/page_load_metrics/OWNERS

+csharrison@chromium.org
+bmcquade@chromium.org
+jkarlin@chromium.org
+ryansturm@chromium.org
+johnidel@chromium.org
+
+# For straightforward addition/removal to existing observers only (for
+# APAC).
+kinuko@chromium.org
+
+# For QUIC version changes in ConnectionInfo switch statmenets.
+per-file protocol_util.cc=file://net/quic/OWNERS
+# COMPONENT: Speed>Metrics

components/page_load_metrics/common/BUILD.gn

@@ -5,7 +5,7 @@
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//testing/test.gni")
 
-static_library("common") {
+source_set("common") {
   sources = [
     "page_end_reason.h",
     "page_load_metrics_constants.h",
@@ -16,14 +16,14 @@ static_library("common") {
   ]
   deps = [
     ":page_load_metrics_mojom",
-    "//base:base",
-    "//net:net",
+    "//base",
+    "//net",
     "//third_party/blink/public:blink_headers",
-    "//url:url",
+    "//url",
   ]
 }
 
-static_library("test_support") {
+source_set("test_support") {
   testonly = true
   sources = [
     "test/page_load_metrics_test_util.cc",

components/page_load_metrics/common/OWNERS

-file://chrome/browser/page_load_metrics/OWNERS
-
-per-file *.mojom=set noparent
-per-file *.mojom=file://ipc/SECURITY_OWNERS
-# COMPONENT: Speed>Metrics

components/page_load_metrics/renderer/BUILD.gn

+# Copyright 2019 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+source_set("renderer") {
+  sources = [
+    "metrics_render_frame_observer.cc",
+    "metrics_render_frame_observer.h",
+    "page_resource_data_use.cc",
+    "page_resource_data_use.h",
+    "page_timing_metrics_sender.cc",
+    "page_timing_metrics_sender.h",
+    "page_timing_sender.h",
+  ]
+  deps = [
+    "//base",
+    "//components/data_reduction_proxy/core/common",
+    "//components/page_load_metrics/common",
+    "//components/page_load_metrics/common:page_load_metrics_mojom",
+    "//components/subresource_filter/content/renderer",
+    "//content/public/common",
+    "//content/public/renderer",
+    "//net",
+    "//services/network/public/cpp",
+    "//third_party/blink/public:blink_headers",
+    "//url",
+  ]
+}
+
+source_set("unit_tests") {
+  testonly = true
+  sources = [
+    "fake_page_timing_sender.cc",
+    "fake_page_timing_sender.h",
+    "metrics_render_frame_observer_unittest.cc",
+    "page_timing_metrics_sender_unittest.cc",
+  ]
+
+  deps = [
+    ":renderer",
+    "//base",
+    "//base/test:test_support",
+    "//components/page_load_metrics/common",
+    "//components/page_load_metrics/common:page_load_metrics_mojom",
+    "//components/page_load_metrics/common:test_support",
+    "//testing/gtest",
+    "//third_party/blink/public:blink_headers",
+    "//url",
+  ]
+}

components/page_load_metrics/renderer/DEPS

+include_rules = [
+  "+base",
+  "+content/public/common",
+  "+content/public/renderer",
+  "+components/data_reduction_proxy/core/common",
+  "+components/subresource_filter/content/renderer",
+  "+services/network/public/cpp",
+  "+third_party/blink/public",
+  "+url",
+]
+
+specific_include_rules = {
+  '.*_[a-z]*test\.cc': [
+     "+testing/gtest"
+  ],
+}

chrome/renderer/page_load_metrics/fake_page_timing_sender.cc → components/page_load_metrics/renderer/fake_page_timing_sender.cc

@@ -2,9 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/page_load_metrics/fake_page_timing_sender.h"
+#include "components/page_load_metrics/renderer/fake_page_timing_sender.h"
 
 #include <algorithm>
+
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace page_load_metrics {

chrome/renderer/page_load_metrics/fake_page_timing_sender.h → components/page_load_metrics/renderer/fake_page_timing_sender.h

@@ -2,15 +2,15 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_FAKE_PAGE_TIMING_SENDER_H_
-#define CHROME_RENDERER_PAGE_LOAD_METRICS_FAKE_PAGE_TIMING_SENDER_H_
+#ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_FAKE_PAGE_TIMING_SENDER_H_
+#define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_FAKE_PAGE_TIMING_SENDER_H_
 
 #include <set>
 #include <vector>
 
-#include "chrome/renderer/page_load_metrics/page_timing_sender.h"
 #include "components/page_load_metrics/common/page_load_metrics.mojom.h"
 #include "components/page_load_metrics/common/page_load_timing.h"
+#include "components/page_load_metrics/renderer/page_timing_sender.h"
 
 namespace page_load_metrics {
 
@@ -124,4 +124,4 @@ class FakePageTimingSender : public PageTimingSender {
 
 }  // namespace page_load_metrics
 
-#endif  // CHROME_RENDERER_PAGE_LOAD_METRICS_FAKE_PAGE_TIMING_SENDER_H_
+#endif  // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_FAKE_PAGE_TIMING_SENDER_H_

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc → components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
+#include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
 
 #include <string>
 #include <utility>
@@ -10,8 +10,8 @@
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
-#include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
-#include "chrome/renderer/page_load_metrics/page_timing_sender.h"
+#include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
+#include "components/page_load_metrics/renderer/page_timing_sender.h"
 #include "content/public/renderer/render_frame.h"
 #include "third_party/blink/public/common/associated_interfaces/associated_interface_provider.h"
 #include "third_party/blink/public/web/web_document.h"

chrome/renderer/page_load_metrics/metrics_render_frame_observer.h → components/page_load_metrics/renderer/metrics_render_frame_observer.h

@@ -2,16 +2,16 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
-#define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
+#ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_METRICS_RENDER_FRAME_OBSERVER_H_
+#define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_METRICS_RENDER_FRAME_OBSERVER_H_
 
 #include <memory>
 #include <set>
 
 #include "base/macros.h"
 #include "base/scoped_observer.h"
-#include "chrome/renderer/page_load_metrics/page_resource_data_use.h"
 #include "components/page_load_metrics/common/page_load_timing.h"
+#include "components/page_load_metrics/renderer/page_resource_data_use.h"
 #include "components/subresource_filter/content/renderer/ad_resource_tracker.h"
 #include "content/public/renderer/render_frame_observer.h"
 #include "third_party/blink/public/platform/web_loading_behavior_flag.h"
@@ -122,4 +122,4 @@ class MetricsRenderFrameObserver
 
 }  // namespace page_load_metrics
 
-#endif  // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
+#endif  // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_METRICS_RENDER_FRAME_OBSERVER_H_

chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc → components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
+#include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
 
 #include <memory>
 #include <utility>
@@ -10,9 +10,9 @@
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "base/timer/mock_timer.h"
-#include "chrome/renderer/page_load_metrics/fake_page_timing_sender.h"
 #include "components/page_load_metrics/common/page_load_timing.h"
 #include "components/page_load_metrics/common/test/weak_mock_timer.h"
+#include "components/page_load_metrics/renderer/fake_page_timing_sender.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 

chrome/renderer/page_load_metrics/page_resource_data_use.cc → components/page_load_metrics/renderer/page_resource_data_use.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/page_load_metrics/page_resource_data_use.h"
+#include "components/page_load_metrics/renderer/page_resource_data_use.h"
 
 #include "base/stl_util.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

chrome/renderer/page_load_metrics/page_resource_data_use.h → components/page_load_metrics/renderer/page_resource_data_use.h

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_RESOURCE_DATA_USE_H_
-#define CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_RESOURCE_DATA_USE_H_
+#ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_RESOURCE_DATA_USE_H_
+#define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_RESOURCE_DATA_USE_H_
 
 #include "base/macros.h"
 #include "components/page_load_metrics/common/page_load_metrics.mojom.h"
@@ -98,4 +98,4 @@ class PageResourceDataUse {
 
 }  // namespace page_load_metrics
 
-#endif  // CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_RESOURCE_DATA_USE_H_
+#endif  // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_RESOURCE_DATA_USE_H_

chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc → components/page_load_metrics/renderer/page_timing_metrics_sender.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
+#include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
 
 #include <utility>
 
@@ -13,8 +13,8 @@
 #include "base/stl_util.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
-#include "chrome/renderer/page_load_metrics/page_timing_sender.h"
 #include "components/page_load_metrics/common/page_load_metrics_constants.h"
+#include "components/page_load_metrics/renderer/page_timing_sender.h"
 #include "services/network/public/cpp/resource_response.h"
 #include "services/network/public/cpp/url_loader_completion_status.h"
 

chrome/renderer/page_load_metrics/page_timing_metrics_sender.h → components/page_load_metrics/renderer/page_timing_metrics_sender.h

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_
-#define CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_
+#ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_
+#define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_
 
 #include <bitset>
 #include <memory>
@@ -11,8 +11,8 @@
 #include "base/containers/flat_set.h"
 #include "base/containers/small_map.h"
 #include "base/macros.h"
-#include "chrome/renderer/page_load_metrics/page_resource_data_use.h"
 #include "components/page_load_metrics/common/page_load_timing.h"
+#include "components/page_load_metrics/renderer/page_resource_data_use.h"
 #include "content/public/common/previews_state.h"
 #include "third_party/blink/public/mojom/use_counter/css_property_id.mojom-shared.h"
 #include "third_party/blink/public/mojom/web_feature/web_feature.mojom-shared.h"
@@ -127,4 +127,4 @@ class PageTimingMetricsSender {
 
 }  // namespace page_load_metrics
 
-#endif  // CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_
+#endif  // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_

chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc → components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc

@@ -2,12 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
+#include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
 
 #include "base/time/time.h"
 #include "base/timer/mock_timer.h"
-#include "chrome/renderer/page_load_metrics/fake_page_timing_sender.h"
 #include "components/page_load_metrics/common/page_load_metrics.mojom.h"
+#include "components/page_load_metrics/renderer/fake_page_timing_sender.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using CSSSampleId = blink::mojom::CSSSampleId;

chrome/renderer/page_load_metrics/page_timing_sender.h → components/page_load_metrics/renderer/page_timing_sender.h

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_SENDER_H_
-#define CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_SENDER_H_
+#ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_SENDER_H_
+#define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_SENDER_H_
 
 #include "components/page_load_metrics/common/page_load_metrics.mojom.h"
 
@@ -26,4 +26,4 @@ class PageTimingSender {
 
 }  // namespace page_load_metrics
 
-#endif  // CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_SENDER_H_
+#endif  // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_SENDER_H_