Commit 36695b3a authored by Hirokazu Honda's avatar Hirokazu Honda Committed by Commit Bot

media/gpu/vaapi: Disable VA-API Low Power Encoder by default

As stated in https://crbug.com/929849#c58, there may be a risk to enable low
power encoder by default. We should perform A/B test via finch. This CL
disables the feature by default, which follows chrome feature release procedure.

Bug: 929849
Test: Confirm EncSliceLP is not used in appr.tc on sarien
Change-Id: I34638d0490d20746cbd630c5cc7bbc8c647b75f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545437
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: default avatarMiguel Casas <mcasas@chromium.org>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646650}
parent 8717c9d8
...@@ -303,6 +303,10 @@ const base::Feature kUnifiedAutoplay{"UnifiedAutoplay", ...@@ -303,6 +303,10 @@ const base::Feature kUnifiedAutoplay{"UnifiedAutoplay",
const base::Feature kUseSurfaceLayerForVideo{"UseSurfaceLayerForVideo", const base::Feature kUseSurfaceLayerForVideo{"UseSurfaceLayerForVideo",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Enable VA-API hardware low power encoder for all codecs.
const base::Feature kVaapiLowPowerEncoder{"VaapiLowPowerEncoder",
base::FEATURE_DISABLED_BY_DEFAULT};
// Enable VA-API hardware encode acceleration for VP8. // Enable VA-API hardware encode acceleration for VP8.
const base::Feature kVaapiVP8Encoder{"VaapiVP8Encoder", const base::Feature kVaapiVP8Encoder{"VaapiVP8Encoder",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
......
...@@ -133,6 +133,7 @@ MEDIA_EXPORT extern const base::Feature kUseModernMediaControls; ...@@ -133,6 +133,7 @@ MEDIA_EXPORT extern const base::Feature kUseModernMediaControls;
MEDIA_EXPORT extern const base::Feature kUseNewMediaCache; MEDIA_EXPORT extern const base::Feature kUseNewMediaCache;
MEDIA_EXPORT extern const base::Feature kUseR16Texture; MEDIA_EXPORT extern const base::Feature kUseR16Texture;
MEDIA_EXPORT extern const base::Feature kUseSurfaceLayerForVideo; MEDIA_EXPORT extern const base::Feature kUseSurfaceLayerForVideo;
MEDIA_EXPORT extern const base::Feature kVaapiLowPowerEncoder;
MEDIA_EXPORT extern const base::Feature kVaapiVP8Encoder; MEDIA_EXPORT extern const base::Feature kVaapiVP8Encoder;
MEDIA_EXPORT extern const base::Feature kVaapiVP9Encoder; MEDIA_EXPORT extern const base::Feature kVaapiVP9Encoder;
MEDIA_EXPORT extern const base::Feature kVideoBlitColorAccuracy; MEDIA_EXPORT extern const base::Feature kVideoBlitColorAccuracy;
......
...@@ -1690,7 +1690,8 @@ bool VaapiWrapper::Initialize(CodecMode mode, VAProfile va_profile) { ...@@ -1690,7 +1690,8 @@ bool VaapiWrapper::Initialize(CodecMode mode, VAProfile va_profile) {
std::vector<VAConfigAttrib> required_attribs = std::vector<VAConfigAttrib> required_attribs =
GetRequiredAttribs(mode, va_profile); GetRequiredAttribs(mode, va_profile);
if ((mode == CodecMode::kEncode) && IsLowPowerEncSupported(va_profile)) { if (mode == CodecMode::kEncode && IsLowPowerEncSupported(va_profile) &&
base::FeatureList::IsEnabled(kVaapiLowPowerEncoder)) {
entrypoint = VAEntrypointEncSliceLP; entrypoint = VAEntrypointEncSliceLP;
DVLOG(2) << "Enable VA-API Low-Power Encode Entrypoint"; DVLOG(2) << "Enable VA-API Low-Power Encode Entrypoint";
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment