Add a flag for developing the Chromevox Developer Option

Bug: 816369
Test: None
Change-Id: Ide3fe8d28b0e2bc9ada51f78595e0c9271ab260b
Reviewed-on: https://chromium-review.googlesource.com/1160838Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#581814}

chrome/browser/about_flags.cc

@@ -4220,6 +4220,13 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kSyncStandaloneTransportDescription, kOsAll,
      FEATURE_VALUE_TYPE(switches::kSyncStandaloneTransport)},
 
+#if defined(OS_CHROMEOS)
+    {"enable-chromevox-developer-option",
+     flag_descriptions::kEnableChromevoxDeveloperOptionName,
+     flag_descriptions::kEnableChromevoxDeveloperOptionDescription, kOsCrOS,
+     SINGLE_VALUE_TYPE(chromeos::switches::kEnableChromevoxDeveloperOption)},
+#endif
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

chrome/browser/flag_descriptions.cc

@@ -443,6 +443,11 @@ const char kEnableCaptivePortalRandomUrl[] = "Captive Portal url Randomization";
 const char kEnableCaptivePortalRandomUrlDescription[] =
     "Enable Captive Portal URL randomization.";
 
+const char kEnableChromevoxDeveloperOptionName[] =
+    "Enable Chromevox developer option";
+const char kEnableChromevoxDeveloperOptionDescription[] =
+    "This option provides tools for developing in chromevox.";
+
 const char kEnableClientLoFiName[] = "Client-side Lo-Fi previews";
 
 const char kEnableClientLoFiDescription[] =

chrome/browser/flag_descriptions.h

@@ -299,6 +299,9 @@ extern const char kEnableBrotliDescription[];
 extern const char kEnableCaptivePortalRandomUrl[];
 extern const char kEnableCaptivePortalRandomUrlDescription[];
 
+extern const char kEnableChromevoxDeveloperOptionName[];
+extern const char kEnableChromevoxDeveloperOptionDescription[];
+
 extern const char kEnableClientLoFiName[];
 extern const char kEnableClientLoFiDescription[];
 

chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html

@@ -130,6 +130,17 @@
     <button id="changeDisplayStyle"></button>
   </div>
 
+  <h2 class="i18n" msgid="options_developer_options" id="developerDescription">
+    Developer Options
+  </h2>
+  <div class="option" id="developerOption">
+    <input id="developerOptionCheckBox" type="checkbox" class="checkbox pref"
+           name="developerOptionCheckBox">
+    <label>
+      Enable developer option test.
+    </label>
+  </div>
+
   <div id="status" role="live" aria-live="assertive">
   </div>
 

chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

@@ -88,6 +88,14 @@ cvox.OptionsPage.init = function() {
     }
   });
 
+  chrome.commandLinePrivate.hasSwitch(
+      'enable-chromevox-developer-option', function(enable) {
+        if (!enable) {
+          $('developerDescription').hidden = true;
+          $('developerOption').hidden = true;
+        }
+      });
+
   Msgs.addTranslatedMessagesToDom(document);
   cvox.OptionsPage.hidePlatformSpecifics();
 

chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd

@@ -559,6 +559,9 @@
       <message desc="An option for setting the key combination that will be used as the ChromeVox modifier key (aka, the 'Cvox' key)." name="IDS_CHROMEVOX_OPTIONS_CVOX_MODIFIER_KEY">
         ChromeVox modifier key
       </message>
+      <message desc="List of chromevox developer options." name="IDS_CHROMEVOX_OPTIONS_DEVELOPER_OPTIONS">
+        Developer Options
+      </message>
       <message desc="The title of ChromeVox Learn Mode page.  The keyboard explorer voices the name of each key when the user presses it." name="IDS_CHROMEVOX_KBEXPLORER_TITLE">
         ChromeVox Learn Mode
       </message>

chromeos/chromeos_switches.cc

@@ -307,6 +307,10 @@ const char kEnableCaptivePortalRandomUrl[] = "enable-captive-portal-random-url";
 // Enables the Cast Receiver.
 const char kEnableCastReceiver[] = "enable-cast-receiver";
 
+// Enables the experimental chromevox developer option.
+const char kEnableChromevoxDeveloperOption[] =
+    "enable-chromevox-developer-option";
+
 // Enables consumer kiosk mode for Chrome OS.
 const char kEnableConsumerKiosk[] = "enable-consumer-kiosk";
 

chromeos/chromeos_switches.h

@@ -91,6 +91,7 @@ CHROMEOS_EXPORT extern const char kEnableArc[];
 CHROMEOS_EXPORT extern const char kEnableArcOobeOptinNoSkip[];
 CHROMEOS_EXPORT extern const char kEnableCaptivePortalRandomUrl[];
 CHROMEOS_EXPORT extern const char kEnableCastReceiver[];
+CHROMEOS_EXPORT extern const char kEnableChromevoxDeveloperOption[];
 CHROMEOS_EXPORT extern const char kEnableConsumerKiosk[];
 CHROMEOS_EXPORT extern const char kEnableDataSaverPrompt[];
 CHROMEOS_EXPORT extern const char kEnableDemoMode[];

tools/metrics/histograms/enums.xml

@@ -28605,6 +28605,7 @@ from previous Chrome versions.
   <int value="-141516902" label="UseModernMediaControls:enabled"/>
   <int value="-138983372" label="DesktopPWAWindowing:disabled"/>
   <int value="-138773929" label="PassiveDocumentEventListeners:enabled"/>
+  <int value="-137303226" label="enable-chromevox-developer-option"/>
   <int value="-135223364" label="AutofillShowTypePredictions:disabled"/>
   <int value="-127231994" label="VrBrowsingNativeAndroidUi:disabled"/>
   <int value="-122492389" label="enable-browser-task-scheduler"/>