Commit 36a2f978 authored by Chris Lu's avatar Chris Lu Committed by Commit Bot

[ios] Add Location Permissions Prompt Experiment Flags

Bug: 1138603
Change-Id: I72ecd463778caa7adac8a0ef041ec01dbd0c5f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486071
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819394}
parent b8dc578a
...@@ -3034,6 +3034,21 @@ ...@@ -3034,6 +3034,21 @@
// external dependencies. // external dependencies.
"expiry_milestone": -1 "expiry_milestone": -1
}, },
{
"name": "location-change-string",
"owners": [ "thegreenfrog", "bling-team" ],
"expiry_milestone": 91
},
{
"name": "location-first-run-modal",
"owners": [ "thegreenfrog", "bling-team" ],
"expiry_milestone": 91
},
{
"name": "location-remove-first-run",
"owners": [ "thegreenfrog", "bling-team" ],
"expiry_milestone": 91
},
{ {
"name": "lock-screen-media-controls", "name": "lock-screen-media-controls",
"owners": [ "beccahughes", "media-dev" ], "owners": [ "beccahughes", "media-dev" ],
......
...@@ -655,6 +655,16 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -655,6 +655,16 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kIncognitoAuthenticationName, flag_descriptions::kIncognitoAuthenticationName,
flag_descriptions::kIncognitoAuthenticationDescription, flags_ui::kOsIos, flag_descriptions::kIncognitoAuthenticationDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kIncognitoAuthentication)}, FEATURE_VALUE_TYPE(kIncognitoAuthentication)},
{"location-first-run-modal", flag_descriptions::kLocationFirstRunModalName,
flag_descriptions::kLocationFirstRunModalDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kLocationFirstRunModal)},
{"location-remove-first-run",
flag_descriptions::kLocationRemoveFirstRunPromptName,
flag_descriptions::kLocationRemoveFirstRunPromptDescription,
flags_ui::kOsIos, FEATURE_VALUE_TYPE(kLocationRemoveFirstRunPrompt)},
{"location-change-string", flag_descriptions::kLocationStringChangeName,
flag_descriptions::kLocationStringChangeDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kLocationStringChange)},
}; };
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) { bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
......
...@@ -323,6 +323,24 @@ const char kIOSLookalikeUrlNavigationSuggestionsUIDescription[] = ...@@ -323,6 +323,24 @@ const char kIOSLookalikeUrlNavigationSuggestionsUIDescription[] =
"When enabled, an interstitial will be shown on navigations to lookalike " "When enabled, an interstitial will be shown on navigations to lookalike "
"URLs."; "URLs.";
const char kLocationFirstRunModalName[] =
"Location Permisssions First Run Modal";
const char kLocationFirstRunModalDescription[] =
"When enabled, a modal detailing location data usage in Chrome will be "
"presented just before triggering the native location permissions prompt.";
const char kLocationRemoveFirstRunPromptName[] =
"Remove Location Permissions Prompt in First Run";
const char kLocationRemoveFirstRunPromptDescription[] =
"When enabled, a location permissions prompt will not be triggered right "
"after First Run anymore.";
const char kLocationStringChangeName[] =
"Use New Location Permissions Prompt String";
const char kLocationStringChangeDescription[] =
"When enabled, a better string will used in the location permissions "
"prompt.";
const char kLockBottomToolbarName[] = "Lock bottom toolbar"; const char kLockBottomToolbarName[] = "Lock bottom toolbar";
const char kLockBottomToolbarDescription[] = const char kLockBottomToolbarDescription[] =
"When enabled, the bottom toolbar will not get collapsed when scrolling " "When enabled, the bottom toolbar will not get collapsed when scrolling "
......
...@@ -279,6 +279,21 @@ extern const char kIOSLegacyTLSInterstitialsDescription[]; ...@@ -279,6 +279,21 @@ extern const char kIOSLegacyTLSInterstitialsDescription[];
extern const char kIOSLookalikeUrlNavigationSuggestionsUIName[]; extern const char kIOSLookalikeUrlNavigationSuggestionsUIName[];
extern const char kIOSLookalikeUrlNavigationSuggestionsUIDescription[]; extern const char kIOSLookalikeUrlNavigationSuggestionsUIDescription[];
// Title and description for the flag to add a First Run modal for location
// permissions.
extern const char kLocationFirstRunModalName[];
extern const char kLocationFirstRunModalDescription[];
// Title and description for the flag to remove the First Run location
// permissions prompt.
extern const char kLocationRemoveFirstRunPromptName[];
extern const char kLocationRemoveFirstRunPromptDescription[];
// Title and description for the flag to change the string in the location
// permissions prompt.
extern const char kLocationStringChangeName[];
extern const char kLocationStringChangeDescription[];
// Title and description for the flag to lock the bottom toolbar into place. // Title and description for the flag to lock the bottom toolbar into place.
extern const char kLockBottomToolbarName[]; extern const char kLockBottomToolbarName[];
extern const char kLockBottomToolbarDescription[]; extern const char kLockBottomToolbarDescription[];
......
...@@ -76,3 +76,12 @@ const base::Feature kModernTabStrip{"ModernTabStrip", ...@@ -76,3 +76,12 @@ const base::Feature kModernTabStrip{"ModernTabStrip",
const base::Feature kIncognitoAuthentication{ const base::Feature kIncognitoAuthentication{
"enable-incognito-authentication-ios", base::FEATURE_DISABLED_BY_DEFAULT}; "enable-incognito-authentication-ios", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kLocationRemoveFirstRunPrompt{
"LocationRemoveFirstRunPrompt", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kLocationStringChange{"LocationStringChange",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kLocationFirstRunModal{"LocationFirstRunModal",
base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -84,4 +84,14 @@ extern const base::Feature kModernTabStrip; ...@@ -84,4 +84,14 @@ extern const base::Feature kModernTabStrip;
// Adds a setting to enable biometric authentication for incognito tabs. // Adds a setting to enable biometric authentication for incognito tabs.
extern const base::Feature kIncognitoAuthentication; extern const base::Feature kIncognitoAuthentication;
// Feature flag that removes the location permissions prompt from First Run.
extern const base::Feature kLocationRemoveFirstRunPrompt;
// Feature flag that changes the string in the location permissions prompt.
extern const base::Feature kLocationStringChange;
// Feature flag that adds a modal in First Run that details Chrome location data
// usage.
extern const base::Feature kLocationFirstRunModal;
#endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_ #endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment