Commit 36a70210 authored by Dana Fried's avatar Dana Fried Committed by Commit Bot

Separate logging event for when a bookmark is launched from app menu.

Requested by Chronav logging initiative.

See attached bug for details.

Bug: 951906
Change-Id: Ia532b16cde546b3cbadc1c52cafc2503a452f9de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574601
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652606}
parent 685475b4
......@@ -37,8 +37,12 @@ bool IsBookmarkBarLocation(BookmarkLaunchLocation location) {
void RecordBookmarkLaunch(const BookmarkNode* node,
BookmarkLaunchLocation location) {
if (IsBookmarkBarLocation(location))
if (IsBookmarkBarLocation(location)) {
base::RecordAction(base::UserMetricsAction("ClickedBookmarkBarURLButton"));
} else if (location == BOOKMARK_LAUNCH_LOCATION_APP_MENU) {
base::RecordAction(
base::UserMetricsAction("WrenchMenu_Bookmarks_LaunchURL"));
}
UMA_HISTOGRAM_ENUMERATION("Bookmarks.LaunchLocation", location,
BOOKMARK_LAUNCH_LOCATION_LIMIT);
......
......@@ -21659,6 +21659,15 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
<action name="WrenchMenu_Bookmarks_LaunchURL">
<owner>dfried@chromium.org</owner>
<description>
The user opened a bookmark from the wrench/application/three-dot menu.
Distinguished from launching from e.g. the bookmarks bar or bookmark
manager.
</description>
</action>
<action name="WrenchMenu_OpenRecentTabFromDevice">
<owner>jwd@chromium.org</owner>
<description>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment