Commit 36aebfaa authored by Tsuyoshi Horo's avatar Tsuyoshi Horo Committed by Commit Bot

Make DevTools support SignedExchange error fallback

Bug: 890199
Change-Id: Idd9d01735d1a922692de63fc7b99e1154b13e7e9
Reviewed-on: https://chromium-review.googlesource.com/1250764Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595590}
parent 514fa3f4
...@@ -780,7 +780,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode { ...@@ -780,7 +780,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
* @return {boolean} * @return {boolean}
*/ */
_isFailed() { _isFailed() {
return (this._request.failed && !this._request.statusCode) || (this._request.statusCode >= 400); return (this._request.failed && !this._request.statusCode) || (this._request.statusCode >= 400) ||
(!!this._request.signedExchangeInfo() && !!this._request.signedExchangeInfo().errors);
} }
/** /**
...@@ -957,7 +958,9 @@ Network.NetworkRequestNode = class extends Network.NetworkNode { ...@@ -957,7 +958,9 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
} else if (this._request.fetchedViaServiceWorker) { } else if (this._request.fetchedViaServiceWorker) {
this._setTextAndTitle(cell, Common.UIString('(from ServiceWorker)')); this._setTextAndTitle(cell, Common.UIString('(from ServiceWorker)'));
cell.classList.add('network-dim-cell'); cell.classList.add('network-dim-cell');
} else if (this._request.redirectSource() && this._request.redirectSource().signedExchangeInfo()) { } else if (
this._request.redirectSource() && this._request.redirectSource().signedExchangeInfo() &&
!this._request.redirectSource().signedExchangeInfo().errors) {
this._setTextAndTitle(cell, Common.UIString('(from signed-exchange)')); this._setTextAndTitle(cell, Common.UIString('(from signed-exchange)'));
cell.classList.add('network-dim-cell'); cell.classList.add('network-dim-cell');
} else if (this._request.cached()) { } else if (this._request.cached()) {
......
...@@ -399,7 +399,9 @@ Network.RequestHeadersView = class extends UI.VBox { ...@@ -399,7 +399,9 @@ Network.RequestHeadersView = class extends UI.VBox {
} else if (this._request.fetchedViaServiceWorker) { } else if (this._request.fetchedViaServiceWorker) {
statusText += ' ' + Common.UIString('(from ServiceWorker)'); statusText += ' ' + Common.UIString('(from ServiceWorker)');
statusTextElement.classList.add('status-from-cache'); statusTextElement.classList.add('status-from-cache');
} else if (this._request.redirectSource() && this._request.redirectSource().signedExchangeInfo()) { } else if (
this._request.redirectSource() && this._request.redirectSource().signedExchangeInfo() &&
!this._request.redirectSource().signedExchangeInfo().errors) {
statusText += ' ' + Common.UIString('(from signed-exchange)'); statusText += ' ' + Common.UIString('(from signed-exchange)');
statusTextElement.classList.add('status-from-cache'); statusTextElement.classList.add('status-from-cache');
} else if (this._request.cached()) { } else if (this._request.cached()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment