Commit 36b4b5b0 authored by Yafei Duan's avatar Yafei Duan Committed by Commit Bot

[Offline Pages] Adding flag for live page sharing.

Adding flag for live page sharing of Offline Pages.

Bug: 870895
Change-Id: Id34ae2ebcc1c83e736505f69a9d78055d3aec94e
Reviewed-on: https://chromium-review.googlesource.com/1162824
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: default avatarDmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581057}
parent 490a1c43
...@@ -249,6 +249,7 @@ public abstract class ChromeFeatureList { ...@@ -249,6 +249,7 @@ public abstract class ChromeFeatureList {
"OfflinePagesDescriptiveFailStatus"; "OfflinePagesDescriptiveFailStatus";
public static final String OFFLINE_PAGES_DESCRIPTIVE_PENDING_STATUS = public static final String OFFLINE_PAGES_DESCRIPTIVE_PENDING_STATUS =
"OfflinePagesDescriptivePendingStatus"; "OfflinePagesDescriptivePendingStatus";
public static final String OFFLINE_PAGES_LIVE_PAGE_SHARING = "OfflinePagesLivePageSharing";
public static final String OFFLINE_PAGES_PREFETCHING = "OfflinePagesPrefetching"; public static final String OFFLINE_PAGES_PREFETCHING = "OfflinePagesPrefetching";
public static final String OMNIBOX_HIDE_SCHEME_DOMAIN_IN_STEADY_STATE = public static final String OMNIBOX_HIDE_SCHEME_DOMAIN_IN_STEADY_STATE =
"OmniboxUIExperimentHideSteadyStateUrlSchemeAndSubdomains"; "OmniboxUIExperimentHideSteadyStateUrlSchemeAndSubdomains";
......
...@@ -2373,6 +2373,10 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -2373,6 +2373,10 @@ const FeatureEntry kFeatureEntries[] = {
{"offline-pages-sharing", flag_descriptions::kOfflinePagesSharingName, {"offline-pages-sharing", flag_descriptions::kOfflinePagesSharingName,
flag_descriptions::kOfflinePagesSharingDescription, kOsAndroid, flag_descriptions::kOfflinePagesSharingDescription, kOsAndroid,
FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)}, FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)},
{"offline-pages-live-page-sharing",
flag_descriptions::kOfflinePagesLivePageSharingName,
flag_descriptions::kOfflinePagesLivePageSharingDescription, kOsAndroid,
FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesLivePageSharingFeature)},
{"offline-pages-prefetching", {"offline-pages-prefetching",
flag_descriptions::kOfflinePagesPrefetchingName, flag_descriptions::kOfflinePagesPrefetchingName,
flag_descriptions::kOfflinePagesPrefetchingDescription, kOsAndroid, flag_descriptions::kOfflinePagesPrefetchingDescription, kOsAndroid,
......
...@@ -161,6 +161,7 @@ const base::Feature* kFeaturesExposedToJava[] = { ...@@ -161,6 +161,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
&offline_pages::kOfflinePagesDescriptiveFailStatusFeature, &offline_pages::kOfflinePagesDescriptiveFailStatusFeature,
&offline_pages::kOfflinePagesDescriptivePendingStatusFeature, &offline_pages::kOfflinePagesDescriptivePendingStatusFeature,
&offline_pages::kOfflinePagesSharingFeature, &offline_pages::kOfflinePagesSharingFeature,
&offline_pages::kOfflinePagesLivePageSharingFeature,
&offline_pages::kPrefetchingOfflinePagesFeature, &offline_pages::kPrefetchingOfflinePagesFeature,
&omnibox::kUIExperimentHideSteadyStateUrlSchemeAndSubdomains, &omnibox::kUIExperimentHideSteadyStateUrlSchemeAndSubdomains,
&password_manager::features::kPasswordExport, &password_manager::features::kPasswordExport,
......
...@@ -2579,6 +2579,12 @@ const char kOfflinePagesSharingName[] = "Enables offline pages to be shared."; ...@@ -2579,6 +2579,12 @@ const char kOfflinePagesSharingName[] = "Enables offline pages to be shared.";
const char kOfflinePagesSharingDescription[] = const char kOfflinePagesSharingDescription[] =
"Enables the saved offline pages to be shared via other applications."; "Enables the saved offline pages to be shared via other applications.";
const char kOfflinePagesLivePageSharingName[] =
"Enables live page sharing of offline pages";
const char kOfflinePagesLivePageSharingDescription[] =
"Enables to share current loaded page as offline page by saving as MHTML "
"first.";
const char kOfflinePagesShowAlternateDinoPageName[] = const char kOfflinePagesShowAlternateDinoPageName[] =
"Enable alternate dino page with more user capabilities."; "Enable alternate dino page with more user capabilities.";
const char kOfflinePagesShowAlternateDinoPageDescription[] = const char kOfflinePagesShowAlternateDinoPageDescription[] =
......
...@@ -1559,6 +1559,9 @@ extern const char kOfflinePagesRenovationsDescription[]; ...@@ -1559,6 +1559,9 @@ extern const char kOfflinePagesRenovationsDescription[];
extern const char kOfflinePagesSharingName[]; extern const char kOfflinePagesSharingName[];
extern const char kOfflinePagesSharingDescription[]; extern const char kOfflinePagesSharingDescription[];
extern const char kOfflinePagesLivePageSharingName[];
extern const char kOfflinePagesLivePageSharingDescription[];
extern const char kOfflinePagesShowAlternateDinoPageName[]; extern const char kOfflinePagesShowAlternateDinoPageName[];
extern const char kOfflinePagesShowAlternateDinoPageDescription[]; extern const char kOfflinePagesShowAlternateDinoPageDescription[];
......
...@@ -34,6 +34,9 @@ const base::Feature kOfflinePagesCTFeature{"OfflinePagesCT", ...@@ -34,6 +34,9 @@ const base::Feature kOfflinePagesCTFeature{"OfflinePagesCT",
const base::Feature kOfflinePagesSharingFeature{ const base::Feature kOfflinePagesSharingFeature{
"OfflinePagesSharing", base::FEATURE_ENABLED_BY_DEFAULT}; "OfflinePagesSharing", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kOfflinePagesLivePageSharingFeature{
"OfflinePagesLivePageSharing", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kOfflinePagesSvelteConcurrentLoadingFeature{ const base::Feature kOfflinePagesSvelteConcurrentLoadingFeature{
"OfflinePagesSvelteConcurrentLoading", base::FEATURE_DISABLED_BY_DEFAULT}; "OfflinePagesSvelteConcurrentLoading", base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -99,6 +102,10 @@ bool IsOfflinePagesSharingEnabled() { ...@@ -99,6 +102,10 @@ bool IsOfflinePagesSharingEnabled() {
return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature); return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature);
} }
bool IsOfflinePagesLivePageSharingEnabled() {
return base::FeatureList::IsEnabled(kOfflinePagesLivePageSharingFeature);
}
bool IsBackgroundLoaderForDownloadsEnabled() { bool IsBackgroundLoaderForDownloadsEnabled() {
return base::FeatureList::IsEnabled(kBackgroundLoaderForDownloadsFeature); return base::FeatureList::IsEnabled(kBackgroundLoaderForDownloadsFeature);
} }
......
...@@ -15,6 +15,7 @@ extern const base::Feature kOffliningRecentPagesFeature; ...@@ -15,6 +15,7 @@ extern const base::Feature kOffliningRecentPagesFeature;
extern const base::Feature kOfflinePagesSvelteConcurrentLoadingFeature; extern const base::Feature kOfflinePagesSvelteConcurrentLoadingFeature;
extern const base::Feature kOfflinePagesCTFeature; extern const base::Feature kOfflinePagesCTFeature;
extern const base::Feature kOfflinePagesSharingFeature; extern const base::Feature kOfflinePagesSharingFeature;
extern const base::Feature kOfflinePagesLivePageSharingFeature;
extern const base::Feature kBackgroundLoaderForDownloadsFeature; extern const base::Feature kBackgroundLoaderForDownloadsFeature;
extern const base::Feature kPrefetchingOfflinePagesFeature; extern const base::Feature kPrefetchingOfflinePagesFeature;
extern const base::Feature kOfflinePagesLoadSignalCollectingFeature; extern const base::Feature kOfflinePagesLoadSignalCollectingFeature;
...@@ -45,6 +46,9 @@ bool IsOfflinePagesCTEnabled(); ...@@ -45,6 +46,9 @@ bool IsOfflinePagesCTEnabled();
// Returns true if offline page sharing is enabled. // Returns true if offline page sharing is enabled.
bool IsOfflinePagesSharingEnabled(); bool IsOfflinePagesSharingEnabled();
// Returns true if live page sharing of offline page is enabled.
bool IsOfflinePagesLivePageSharingEnabled();
// Returns true if saving a foreground tab that is taking too long using the // Returns true if saving a foreground tab that is taking too long using the
// background scheduler is enabled. // background scheduler is enabled.
bool IsBackgroundLoaderForDownloadsEnabled(); bool IsBackgroundLoaderForDownloadsEnabled();
......
...@@ -40,6 +40,17 @@ TEST(OfflinePageFeatureTest, OfflinePagesSharing) { ...@@ -40,6 +40,17 @@ TEST(OfflinePageFeatureTest, OfflinePagesSharing) {
EXPECT_TRUE(offline_pages::IsOfflinePagesSharingEnabled()); EXPECT_TRUE(offline_pages::IsOfflinePagesSharingEnabled());
} }
TEST(OfflinePageFeatureTest, OfflinePagesLivePageSharing) {
// Disabled by default.
EXPECT_FALSE(
base::FeatureList::IsEnabled(kOfflinePagesLivePageSharingFeature));
// Check if helper method works correctly when the feature is disabled.
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(kOfflinePagesLivePageSharingFeature);
EXPECT_TRUE(offline_pages::IsOfflinePagesLivePageSharingEnabled());
}
TEST(OfflinePageFeatureTest, OfflinePagesSvelteConcurrentLoading) { TEST(OfflinePageFeatureTest, OfflinePagesSvelteConcurrentLoading) {
// Disabled by default. // Disabled by default.
EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled()); EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
......
...@@ -27783,6 +27783,7 @@ from previous Chrome versions. ...@@ -27783,6 +27783,7 @@ from previous Chrome versions.
<int value="-1767470652" label="out-of-process-pdf"/> <int value="-1767470652" label="out-of-process-pdf"/>
<int value="-1758468685" label="DownloadHomeV2:disabled"/> <int value="-1758468685" label="DownloadHomeV2:disabled"/>
<int value="-1755301960" label="ClearOldBrowsingData:enabled"/> <int value="-1755301960" label="ClearOldBrowsingData:enabled"/>
<int value="-1753458842" label="OfflinePagesLivePageSharing:disabled"/>
<int value="-1751928267" label="disable-icon-ntp"/> <int value="-1751928267" label="disable-icon-ntp"/>
<int value="-1749176684" label="PauseBackgroundTabs:disabled"/> <int value="-1749176684" label="PauseBackgroundTabs:disabled"/>
<int value="-1746767834" label="ssl-interstitial-v2-gray"/> <int value="-1746767834" label="ssl-interstitial-v2-gray"/>
...@@ -29219,6 +29220,7 @@ from previous Chrome versions. ...@@ -29219,6 +29220,7 @@ from previous Chrome versions.
<int value="1194496204" label="NewWallpaperPicker:enabled"/> <int value="1194496204" label="NewWallpaperPicker:enabled"/>
<int value="1196644408" label="performance-monitor-gathering"/> <int value="1196644408" label="performance-monitor-gathering"/>
<int value="1196834473" label="disable-smart-virtual-keyboard"/> <int value="1196834473" label="disable-smart-virtual-keyboard"/>
<int value="1198839129" label="OfflinePagesLivePageSharing:enabled"/>
<int value="1201441984" <int value="1201441984"
label="new-password-form-parsing-for-saving:disabled"/> label="new-password-form-parsing-for-saving:disabled"/>
<int value="1205849612" label="enable-sync-synced-notifications"/> <int value="1205849612" label="enable-sync-synced-notifications"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment