Commit 36cc7655 authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot

Semi-revert "[content] Fix navigation in LockObserver browser tests."

The patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1854901

was reenabling the tests:
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverDedicatedWorker
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverNavigate
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverServiceWorker
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverSingleConnection
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverTwoLocks
- LockManagerBrowserTest.ObserverDedicatedWorker
- LockManagerBrowserTest.ObserverNavigate
- LockManagerBrowserTest.ObserverServiceWorker
- LockManagerBrowserTest.ObserverSingleLock
- LockManagerBrowserTest.ObserverStealLock
- LockManagerBrowserTest.ObserverTwoLocks

on Android KitKat.

They are still failing => disabling them again.
https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/18113

TBR=fdoray@chromium.org
CC=ahemery@chromium.org,fergal@chromium.org,altimin@chromium.org
R=arthursonzogni@chromium.org

Bug: 1019659,1011765,1014015
Change-Id: I5be59757f1f37d58150700c331c22cbd8343187f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890071Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710762}
parent 649be46e
...@@ -102,6 +102,13 @@ class IndexedDBExecutionContextConnectionTrackerBrowserTest ...@@ -102,6 +102,13 @@ class IndexedDBExecutionContextConnectionTrackerBrowserTest
// on Android Kitkat or older systems. // on Android Kitkat or older systems.
if (!original_client_) if (!original_client_)
return false; return false;
// TODO(https://crbug.com/1011765, https://crbug.com/1019659):
// Navigation fails on Android Kit Kat.
if (base::android::BuildInfo::GetInstance()->sdk_int() <=
base::android::SDK_VERSION_KITKAT) {
return false;
}
#endif // defined(OS_ANDROID) #endif // defined(OS_ANDROID)
EXPECT_TRUE(NavigateToURL(shell(), GetTestURL("a.com"))); EXPECT_TRUE(NavigateToURL(shell(), GetTestURL("a.com")));
return true; return true;
......
...@@ -103,6 +103,13 @@ class LockManagerBrowserTest : public ContentBrowserTest { ...@@ -103,6 +103,13 @@ class LockManagerBrowserTest : public ContentBrowserTest {
// on Android Kitkat or older systems. // on Android Kitkat or older systems.
if (!original_client_) if (!original_client_)
return false; return false;
// TODO(https://crbug.com/1011765, https://crbug.com/1019659):
// Navigation fails on Android Kit Kat.
if (base::android::BuildInfo::GetInstance()->sdk_int() <=
base::android::SDK_VERSION_KITKAT) {
return false;
}
#endif // defined(OS_ANDROID) #endif // defined(OS_ANDROID)
EXPECT_TRUE(NavigateToURL(shell(), GetLocksURL("a.com"))); EXPECT_TRUE(NavigateToURL(shell(), GetLocksURL("a.com")));
return true; return true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment