CodeHealthRotation: migrate Bind to BindOnce/Repeating in c/b/profiles/profile_shortcut_manager*

This change migrates uses of base::Bind to BindOnce/BindRepeating, and
uses of base::Callback to OnceCallback/RepeatingCallback.

Please see crbug.com/714018 for full details about the migration.

Bug: 1147284
Change-Id: Iaca33379eb8d81e667488bbdbc6fb8b053fcfd1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534609
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827200}

chrome/browser/profiles/profile_shortcut_manager.h

@@ -44,9 +44,8 @@ class ProfileShortcutManager {
   // Checks if a profile at |profile_path| has any shortcuts and invokes
   // |callback| with the bool result some time later. Does not consider
   // non-profile specific shortcuts.
-  virtual void HasProfileShortcuts(
-      const base::FilePath& profile_path,
-      const base::Callback<void(bool)>& callback) = 0;
+  virtual void HasProfileShortcuts(const base::FilePath& profile_path,
+                                   base::OnceCallback<void(bool)> callback) = 0;
 
   // Populates the |command_line|, |name| and |icon_path| that a shortcut for
   // the given |profile_path| should use.

chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc

@@ -739,12 +739,10 @@ TEST_F(ProfileShortcutManagerTest, HasProfileShortcuts) {
     void set_has_shortcuts(bool value) { has_shortcuts = value; }
   } result = { false };
 
-  const base::Callback<void(bool)> callback =
-      base::Bind(&HasShortcutsResult::set_has_shortcuts,
-                 base::Unretained(&result));
-
   // Profile 2 should have a shortcut initially.
-  profile_shortcut_manager_->HasProfileShortcuts(profile_2_path_, callback);
+  profile_shortcut_manager_->HasProfileShortcuts(
+      profile_2_path_, base::BindOnce(&HasShortcutsResult::set_has_shortcuts,
+                                      base::Unretained(&result)));
   task_environment_.RunUntilIdle();
   EXPECT_TRUE(result.has_shortcuts);
 
@@ -753,7 +751,9 @@ TEST_F(ProfileShortcutManagerTest, HasProfileShortcuts) {
       GetDefaultShortcutPathForProfile(profile_2_name_);
   ASSERT_TRUE(base::DeleteFile(profile_2_shortcut_path));
   EXPECT_FALSE(base::PathExists(profile_2_shortcut_path));
-  profile_shortcut_manager_->HasProfileShortcuts(profile_2_path_, callback);
+  profile_shortcut_manager_->HasProfileShortcuts(
+      profile_2_path_, base::BindOnce(&HasShortcutsResult::set_has_shortcuts,
+                                      base::Unretained(&result)));
   task_environment_.RunUntilIdle();
   EXPECT_FALSE(result.has_shortcuts);
 }

chrome/browser/profiles/profile_shortcut_manager_win.cc

@@ -791,11 +791,11 @@ void ProfileShortcutManagerWin::RemoveProfileShortcuts(
 
 void ProfileShortcutManagerWin::HasProfileShortcuts(
     const base::FilePath& profile_path,
-    const base::Callback<void(bool)>& callback) {
+    base::OnceCallback<void(bool)> callback) {
   base::PostTaskAndReplyWithResult(
       base::ThreadPool::CreateCOMSTATaskRunner({base::MayBlock()}).get(),
       FROM_HERE, base::BindOnce(&HasAnyProfileShortcuts, profile_path),
-      base::BindOnce(callback));
+      base::BindOnce(std::move(callback)));
 }
 
 void ProfileShortcutManagerWin::GetShortcutProperties(

chrome/browser/profiles/profile_shortcut_manager_win.h

@@ -93,7 +93,7 @@ class ProfileShortcutManagerWin : public ProfileShortcutManager,
   void CreateProfileShortcut(const base::FilePath& profile_path) override;
   void RemoveProfileShortcuts(const base::FilePath& profile_path) override;
   void HasProfileShortcuts(const base::FilePath& profile_path,
-                           const base::Callback<void(bool)>& callback) override;
+                           base::OnceCallback<void(bool)> callback) override;
   void GetShortcutProperties(const base::FilePath& profile_path,
                              base::CommandLine* command_line,
                              base::string16* name,

chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc

@@ -233,8 +233,8 @@ void ManageProfileHandler::HandleRequestProfileShortcutStatus(
   DCHECK(shortcut_manager);
   shortcut_manager->HasProfileShortcuts(
       profile_->GetPath(),
-      base::Bind(&ManageProfileHandler::OnHasProfileShortcuts,
-                 weak_factory_.GetWeakPtr(), callback_id));
+      base::BindOnce(&ManageProfileHandler::OnHasProfileShortcuts,
+                     weak_factory_.GetWeakPtr(), callback_id));
 }
 
 void ManageProfileHandler::OnHasProfileShortcuts(