Cleanup remaining post-migration settings TODOs
The most important simplifications that were tracked by this bug have been completed (getting rid of KitKat customizations and switching to the material defaults). These lingering small TODOs can be removed. AndroidPaymentAppPreference.java: There's pros and cons to using a custom layout vs making layout changes at runtime. I generally prefer custom layouts in XML, but it's probably not worth the effort and testing to go back and change this one after the fact. storage_preferences_view.xml: The default support library empty state has smaller text, and can't be customized, so this should stay as is (UI is by design). Bug: 971791 Change-Id: Ie45ea27a39f8f4c66112152913864925f3bd5167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630067 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#843733}
Showing
Please register or sign in to comment