Update Safe Browsing billing interstitial tab title

The current implementation in Chrome shows "Security Error".
The title should be "Page may charge money" instead.

Bug: 913889
Change-Id: I8655217cadc4e481d149ad5a80520367148dc2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732309Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684134}

android_webview/ui/grit_strings_whitelist.txt

@@ -16,6 +16,7 @@ IDS_HARMFUL_V3_PRIMARY_PARAGRAPH
 IDS_HARMFUL_V3_EXPLANATION_PARAGRAPH
 IDS_HARMFUL_V3_EXPLANATION_PARAGRAPH_SUBRESOURCE
 IDS_HARMFUL_V3_PROCEED_PARAGRAPH
+IDS_BILLING_TITLE
 IDS_BILLING_HEADING
 IDS_BILLING_PRIMARY_PARAGRAPH
 IDS_BILLING_PRIMARY_BUTTON

chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

@@ -150,7 +150,7 @@ IN_PROC_BROWSER_TEST_F(InterstitialUITest, UnwantedSoftwareInterstitialQuiet) {
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, BillingInterstitialQuiet) {
   TestInterstitial(
       GURL("chrome://interstitials/quietsafebrowsing?type=billing"),
-      "Security error", IDS_BILLING_WEBVIEW_HEADING);
+      "Page may charge money", IDS_BILLING_WEBVIEW_HEADING);
 }
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, ClientsideMalwareInterstitial) {
@@ -167,7 +167,7 @@ IN_PROC_BROWSER_TEST_F(InterstitialUITest, ClientsidePhishingInterstitial) {
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, BillingInterstitial) {
   TestInterstitial(GURL("chrome://interstitials/safebrowsing?type=billing"),
-                   "Security error", IDS_BILLING_HEADING);
+                   "Page may charge money", IDS_BILLING_HEADING);
 }
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, CaptivePortalInterstitial) {

components/security_interstitials/core/safe_browsing_loud_error_ui.cc

@@ -314,6 +314,8 @@ void SafeBrowsingLoudErrorUI::PopulateBillingLoadTimeData(
   load_time_data->SetBoolean("phishing", false);
   load_time_data->SetBoolean("overridable", true);
 
+  load_time_data->SetString("tabTitle",
+                            l10n_util::GetStringUTF16(IDS_BILLING_TITLE));
   load_time_data->SetString("heading",
                             l10n_util::GetStringUTF16(IDS_BILLING_HEADING));
   load_time_data->SetString(

components/security_interstitials/core/safe_browsing_quiet_error_ui.cc

@@ -152,6 +152,8 @@ void SafeBrowsingQuietErrorUI::PopulatePhishingLoadTimeData(
 void SafeBrowsingQuietErrorUI::PopulateBillingLoadTimeData(
     base::DictionaryValue* load_time_data) {
   load_time_data->SetBoolean("phishing", false);
+  load_time_data->SetString("tabTitle",
+                            l10n_util::GetStringUTF16(IDS_BILLING_TITLE));
   load_time_data->SetString(
       "heading", l10n_util::GetStringUTF16(IDS_BILLING_WEBVIEW_HEADING));
   load_time_data->SetString(

components/security_interstitials_strings.grdp

@@ -405,6 +405,9 @@
   </if>
 
   <!-- Billing interstitial -->
+  <message name="IDS_BILLING_TITLE" desc="The tab title for the Safe Browsing Billing interstitial.">
+    Page may charge money
+  </message>
   <message name="IDS_BILLING_HEADING" desc="The large heading at the top of the billing interstitial.">
     The page ahead may try to charge you money
   </message>

components/security_interstitials_strings_grdp/IDS_BILLING_TITLE.png.sha1

+a8634b9ed4f8e7829c25a89ef83b68217d0c564c
\ No newline at end of file