GitLab

Merge URLLoaderRequestController into NavigationURLLoaderImpl

This inner class (URLLoaderRequestController) was introduced
because the most of loading related code used to need to run on
IO thread (while NavigationURLLoader itself needs to run on UI
thread), while now everything can just run on UI thread.

This change merges URLLoaderRequestController back
to NavigationURLLoaderImpl.

It looks like a lot more code cleanup can be made but leaving
those TODOs in order to make the diff relatively cleaner.

(The diff still looks a bit broken but no major changes are made
in the existing code)

Changed NavigationURLLoaderImpl's some method names too to avoid
confusion (because now it also needs to have URLLoaderClient methods)
* OnRequestStarted --> NotifyRequestStarted
* OnReceiveResponse --> NotifyResponseStarted
* OnReceiveRedirect --> NotifyRequestRedirected
* OnComplete --> NotifyRequestFailed

Bug: 1068896
Change-Id: I9d9dc5acf06816dc1bc73fd24a9b7ed4bb915dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212189
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771699}