Commit 752e5a01 authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

Enable SyncInstanceIDTokenTTL by default on Win/Mac/Linux

Also change the default value for its TTL parameter to 14 days (instead
of 28), which is the value that's launching.

Bug: 1034915
Change-Id: I0cef3d09878af50a4d465122f2ff8f84f4eccd99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214387
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771698}
parent d0095703
...@@ -4,14 +4,16 @@ ...@@ -4,14 +4,16 @@
#include "components/invalidation/impl/invalidation_switches.h" #include "components/invalidation/impl/invalidation_switches.h"
#include "build/build_config.h"
namespace invalidation { namespace invalidation {
namespace switches { namespace switches {
namespace { namespace {
// Default TTL (if the SyncInstanceIDTokenTTL/PolicyInstanceIDTokenTTL feature // Default TTL (if the SyncInstanceIDTokenTTL/PolicyInstanceIDTokenTTL feature
// is enabled) is 4 weeks. Exposed for testing. // is enabled) is 2 weeks. Exposed for testing.
const int kDefaultInstanceIDTokenTTLSeconds = 28 * 24 * 60 * 60; const int kDefaultInstanceIDTokenTTLSeconds = 14 * 24 * 60 * 60;
} // namespace } // namespace
...@@ -32,8 +34,15 @@ const base::Feature kTiclInvalidationsStartInvalidatorOnActiveHandler = { ...@@ -32,8 +34,15 @@ const base::Feature kTiclInvalidationsStartInvalidatorOnActiveHandler = {
"TiclInvalidationsStartInvalidatorOnActiveHandler", "TiclInvalidationsStartInvalidatorOnActiveHandler",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kSyncInstanceIDTokenTTL{"SyncInstanceIDTokenTTL", const base::Feature kSyncInstanceIDTokenTTL {
base::FEATURE_DISABLED_BY_DEFAULT}; "SyncInstanceIDTokenTTL",
#if defined(OS_WIN) || (defined(OS_MACOSX) && !defined(OS_IOS)) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
#endif
};
const base::FeatureParam<int> kSyncInstanceIDTokenTTLSeconds{ const base::FeatureParam<int> kSyncInstanceIDTokenTTLSeconds{
&kSyncInstanceIDTokenTTL, "time_to_live_seconds", &kSyncInstanceIDTokenTTL, "time_to_live_seconds",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment