Re-collecting active sheets should work for media query changes

Forcing re-adding all sheets should not be necessary. I probably was at
some point. Now, the active style update process should handle all.

TEST=StyleEngine.StyleMediaAttributeStyleChange
TEST=StyleEngine.StyleMediaAttributeNoStyleChange

Change-Id: Ie5af77ca90768b8fe5a39c3e07ddd5025f1c1056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563469Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831826}

third_party/blink/renderer/core/css/style_engine.cc

@@ -432,12 +432,6 @@ void StyleEngine::MediaQueryAffectingValueChanged(TreeScope& tree_scope,
   }
 }
 
-void StyleEngine::MediaQueriesChangedInScope(TreeScope& tree_scope) {
-  if (ScopedStyleResolver* resolver = tree_scope.GetScopedStyleResolver())
-    resolver->SetNeedsAppendAllSheets();
-  SetNeedsActiveStyleUpdate(tree_scope);
-}
-
 void StyleEngine::WatchedSelectorsChanged() {
   DCHECK(!IsHTMLImport());
   DCHECK(global_rule_set_);

third_party/blink/renderer/core/css/style_engine.h

@@ -154,7 +154,6 @@ class CORE_EXPORT StyleEngine final : public GarbageCollected<StyleEngine>,
       const HeapVector<Member<CSSStyleSheet>>& new_sheets);
   void AddedCustomElementDefaultStyles(
       const HeapVector<Member<CSSStyleSheet>>& default_styles);
-  void MediaQueriesChangedInScope(TreeScope&);
   void WatchedSelectorsChanged();
   void InitialStyleChanged();
   void ColorSchemeChanged();

third_party/blink/renderer/core/html/html_style_element.cc

@@ -49,7 +49,7 @@ void HTMLStyleElement::ParseAttribute(
              GetDocument().IsActive() && sheet_) {
     sheet_->SetMediaQueries(
         MediaQuerySet::Create(params.new_value, GetExecutionContext()));
-    GetDocument().GetStyleEngine().MediaQueriesChangedInScope(GetTreeScope());
+    GetDocument().GetStyleEngine().SetNeedsActiveStyleUpdate(GetTreeScope());
   } else if (params.name == html_names::kTypeAttr) {
     HTMLElement::ParseAttribute(params);
     StyleElement::ChildrenChanged(*this);