Commit 37539533 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Remove expired PrintPreview UMA collection code.

- PrintPreview.RegeneratePreviewRequest.BeforeFirstData:
  The UMA is not interesting.
- PrintPreview.ManagePrinters:
  https://crrev.com/518333 botched the data collection code, and
  https://crrev.com/613267 removed the method that should have
  collected the data.

Along the way, initialize more PrintPreviewHandler member variables in
the header.

Bug: 1041532
Change-Id: I319d87c17d11ee9191e9feba6351fe93f5aa44fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135534Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756388}
parent 293f0a22
...@@ -522,18 +522,11 @@ class PrintPreviewHandler::AccessTokenService ...@@ -522,18 +522,11 @@ class PrintPreviewHandler::AccessTokenService
}; };
#endif // defined(OS_CHROMEOS) #endif // defined(OS_CHROMEOS)
PrintPreviewHandler::PrintPreviewHandler() PrintPreviewHandler::PrintPreviewHandler() {
: regenerate_preview_request_count_(0),
manage_printers_dialog_request_count_(0),
reported_failed_preview_(false),
has_logged_printers_count_(false),
identity_manager_(nullptr) {
ReportUserActionHistogram(PREVIEW_STARTED); ReportUserActionHistogram(PREVIEW_STARTED);
} }
PrintPreviewHandler::~PrintPreviewHandler() { PrintPreviewHandler::~PrintPreviewHandler() {
base::UmaHistogramCounts1M("PrintPreview.ManagePrinters",
manage_printers_dialog_request_count_);
UnregisterForGaiaCookieChanges(); UnregisterForGaiaCookieChanges();
} }
...@@ -1005,7 +998,6 @@ void PrintPreviewHandler::HandleGetAccessToken(const base::ListValue* args) { ...@@ -1005,7 +998,6 @@ void PrintPreviewHandler::HandleGetAccessToken(const base::ListValue* args) {
#if BUILDFLAG(ENABLE_BASIC_PRINT_DIALOG) #if BUILDFLAG(ENABLE_BASIC_PRINT_DIALOG)
void PrintPreviewHandler::HandleShowSystemDialog( void PrintPreviewHandler::HandleShowSystemDialog(
const base::ListValue* /*args*/) { const base::ListValue* /*args*/) {
manage_printers_dialog_request_count_++;
ReportUserActionHistogram(FALLBACK_TO_ADVANCED_SETTINGS_DIALOG); ReportUserActionHistogram(FALLBACK_TO_ADVANCED_SETTINGS_DIALOG);
WebContents* initiator = GetInitiator(); WebContents* initiator = GetInitiator();
......
...@@ -97,10 +97,6 @@ class PrintPreviewHandler : public content::WebUIMessageHandler, ...@@ -97,10 +97,6 @@ class PrintPreviewHandler : public content::WebUIMessageHandler,
int preview_uid, int preview_uid,
int preview_request_id); int preview_request_id);
int regenerate_preview_request_count() const {
return regenerate_preview_request_count_;
}
// Notifies PDF Printer Handler that |path| was selected. Used for tests. // Notifies PDF Printer Handler that |path| was selected. Used for tests.
void FileSelectedForTesting(const base::FilePath& path, void FileSelectedForTesting(const base::FilePath& path,
int index, int index,
...@@ -314,16 +310,13 @@ class PrintPreviewHandler : public content::WebUIMessageHandler, ...@@ -314,16 +310,13 @@ class PrintPreviewHandler : public content::WebUIMessageHandler,
// A count of how many requests received to regenerate preview data. // A count of how many requests received to regenerate preview data.
// Initialized to 0 then incremented and emitted to a histogram. // Initialized to 0 then incremented and emitted to a histogram.
int regenerate_preview_request_count_; int regenerate_preview_request_count_ = 0;
// A count of how many requests received to show manage printers dialog.
int manage_printers_dialog_request_count_;
// Whether we have already logged a failed print preview. // Whether we have already logged a failed print preview.
bool reported_failed_preview_; bool reported_failed_preview_ = false;
// Whether we have already logged the number of printers this session. // Whether we have already logged the number of printers this session.
bool has_logged_printers_count_; bool has_logged_printers_count_ = false;
// Whether Google Cloud Print is enabled for the active profile. // Whether Google Cloud Print is enabled for the active profile.
bool cloud_print_enabled_ = false; bool cloud_print_enabled_ = false;
...@@ -338,7 +331,7 @@ class PrintPreviewHandler : public content::WebUIMessageHandler, ...@@ -338,7 +331,7 @@ class PrintPreviewHandler : public content::WebUIMessageHandler,
// Pointer to the identity manager service so that print preview can listen // Pointer to the identity manager service so that print preview can listen
// for GAIA cookie changes. // for GAIA cookie changes.
signin::IdentityManager* identity_manager_; signin::IdentityManager* identity_manager_ = nullptr;
// Handles requests for cloud printers. Created lazily by calling // Handles requests for cloud printers. Created lazily by calling
// GetPrinterHandler(). // GetPrinterHandler().
......
...@@ -675,9 +675,6 @@ void PrintPreviewUI::OnPreviewDataIsAvailable( ...@@ -675,9 +675,6 @@ void PrintPreviewUI::OnPreviewDataIsAvailable(
base::UmaHistogramTimes( base::UmaHistogramTimes(
"PrintPreview.InitialDisplayTime", "PrintPreview.InitialDisplayTime",
base::TimeTicks::Now() - initial_preview_start_time_); base::TimeTicks::Now() - initial_preview_start_time_);
base::UmaHistogramCounts1M(
"PrintPreview.RegeneratePreviewRequest.BeforeFirstData",
handler_->regenerate_preview_request_count());
initial_preview_start_time_ = base::TimeTicks(); initial_preview_start_time_ = base::TimeTicks();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment