Fix bug where the wrong color is shown for tab hover cards after switching...

Fix bug where the wrong color is shown for tab hover cards after switching between system light/dark modes.

The fade label child views are set to be ignored by tab hover card layout. This means the background color is not updated for these labels after creation. This change update the color before an animation would take place.

Bug: 1030328
Change-Id: I8204978fc8983f4ff4b3cc02922a0401cf039244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951090
Commit-Queue: Caroline Rising <corising@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721727}

chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc

@@ -798,6 +798,15 @@ gfx::Size TabHoverCardBubbleView::CalculatePreferredSize() const {
   return preferred_size;
 }
 
+void TabHoverCardBubbleView::OnThemeChanged() {
+  BubbleDialogDelegateView::OnThemeChanged();
+
+  // Update fade labels' background color to match that of the the original
+  // label since these child views are ignored by layout.
+  title_fade_label_->SetBackgroundColor(title_label_->GetBackgroundColor());
+  domain_fade_label_->SetBackgroundColor(domain_label_->GetBackgroundColor());
+}
+
 void TabHoverCardBubbleView::RecordTimeSinceLastSeenMetric(
     base::TimeDelta elapsed_time) {
   constexpr base::TimeDelta kMaxHoverCardReshowTimeDelta =

chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h

@@ -89,6 +89,7 @@ class TabHoverCardBubbleView : public views::BubbleDialogDelegateView {
 
   // views::BubbleDialogDelegateView:
   gfx::Size CalculatePreferredSize() const override;
+  void OnThemeChanged() override;
 
   void RecordTimeSinceLastSeenMetric(base::TimeDelta elapsed_time);