Commit 379beabb authored by Vadim Tryshev's avatar Vadim Tryshev Committed by Commit Bot

Not eating Space button.

Answer card eats Space, so that pressing space while it's selected
doesn't add space to the search box. So if you start typing a query with
a space, you might be not able to enter space.

Other kinds of results don't eat space.

Now not eating Space.

Bug=712331

Change-Id: If7bb4224d6d2597bd50e31eececc184d7f401904
Reviewed-on: https://chromium-review.googlesource.com/595154Reviewed-by: default avatarYury Khmel <khmel@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491583}
parent 0419e2ca
...@@ -79,6 +79,15 @@ class SearchResultAnswerCardView::SearchAnswerContainerView ...@@ -79,6 +79,15 @@ class SearchResultAnswerCardView::SearchAnswerContainerView
void StateChanged(ButtonState old_state) override { UpdateBackgroundColor(); } void StateChanged(ButtonState old_state) override { UpdateBackgroundColor(); }
bool OnKeyPressed(const ui::KeyEvent& event) override {
if (event.key_code() == ui::VKEY_SPACE) {
// Shouldn't eat Space; we want Space to go to the search box.
return false;
}
return CustomButton::OnKeyPressed(event);
}
// views::ButtonListener overrides: // views::ButtonListener overrides:
void ButtonPressed(views::Button* sender, const ui::Event& event) override { void ButtonPressed(views::Button* sender, const ui::Event& event) override {
DCHECK(sender == this); DCHECK(sender == this);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment