Commit 37a7e0f9 authored by Dale Curtis's avatar Dale Curtis Committed by Commit Bot

Disable PulseAudio for ASAN and TSAN configurations.

For some reason we're hanging in pa_context_connect(). We could do this
in a thread, but it's unclear this is a production Chrome problem, so
just disable for now.

R=jrummell

Bug: 986021, 1047655
Change-Id: I1042413690795016a28f4180eb7ea8f8c79e543f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050785
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: default avatarJohn Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740429}
parent 9a8afe6e
...@@ -128,7 +128,14 @@ declare_args() { ...@@ -128,7 +128,14 @@ declare_args() {
use_alsa = true use_alsa = true
# Pulse is not supported on Chromecast platforms. # Pulse is not supported on Chromecast platforms.
if (!use_cras && !is_chromecast) { #
# ASAN and TSAN will occasionally hang during pa_context_connect(), so we
# disable PulseAudio when these configurations are enabled.
#
# TODO(crbug.com/986021): We shouldn't have to do this, but it's unclear why
# our test bots are hanging and all of the ones that don't hang just fall
# back to ALSA after a connection error anyways.
if (!use_cras && !is_chromecast && !is_asan && !is_tsan) {
use_pulseaudio = true use_pulseaudio = true
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment