Commit 37c5e5e6 authored by Hwanseung Lee's avatar Hwanseung Lee Committed by Commit Bot

[css-typed-om] values attribute should be readonly

values attribute should be immutable to prevent cyclic
references in CSSMathMax, CSSMathMin, CSSMathProduct,
CSSMathSum.

Bug: 803687
Change-Id: Ibb93165ffd7a279a80febba0543ac186b67dbe56
Reviewed-on: https://chromium-review.googlesource.com/890558Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#532336}
parent 716357ac
...@@ -18,11 +18,9 @@ CONSOLE MESSAGE: line 147: setter value ...@@ -18,11 +18,9 @@ CONSOLE MESSAGE: line 147: setter value
CONSOLE MESSAGE: line 147: interface CSSMathMax : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathMax : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathMin : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathMin : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathNegate : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathNegate : CSSMathValue
CONSOLE MESSAGE: line 147: getter value CONSOLE MESSAGE: line 147: getter value
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
...@@ -30,11 +28,9 @@ CONSOLE MESSAGE: line 147: setter value ...@@ -30,11 +28,9 @@ CONSOLE MESSAGE: line 147: setter value
CONSOLE MESSAGE: line 147: interface CSSMathProduct : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathProduct : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathSum : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathSum : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathValue : CSSNumericValue CONSOLE MESSAGE: line 147: interface CSSMathValue : CSSNumericValue
CONSOLE MESSAGE: line 147: getter operator CONSOLE MESSAGE: line 147: getter operator
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
...@@ -308,11 +304,9 @@ CONSOLE MESSAGE: line 147: setter value ...@@ -308,11 +304,9 @@ CONSOLE MESSAGE: line 147: setter value
CONSOLE MESSAGE: line 147: interface CSSMathMax : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathMax : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathMin : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathMin : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathNegate : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathNegate : CSSMathValue
CONSOLE MESSAGE: line 147: getter value CONSOLE MESSAGE: line 147: getter value
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
...@@ -320,11 +314,9 @@ CONSOLE MESSAGE: line 147: setter value ...@@ -320,11 +314,9 @@ CONSOLE MESSAGE: line 147: setter value
CONSOLE MESSAGE: line 147: interface CSSMathProduct : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathProduct : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathSum : CSSMathValue CONSOLE MESSAGE: line 147: interface CSSMathSum : CSSMathValue
CONSOLE MESSAGE: line 147: getter values CONSOLE MESSAGE: line 147: getter values
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
CONSOLE MESSAGE: line 147: setter values
CONSOLE MESSAGE: line 147: interface CSSMathValue : CSSNumericValue CONSOLE MESSAGE: line 147: interface CSSMathValue : CSSNumericValue
CONSOLE MESSAGE: line 147: getter operator CONSOLE MESSAGE: line 147: getter operator
CONSOLE MESSAGE: line 147: method constructor CONSOLE MESSAGE: line 147: method constructor
......
...@@ -651,12 +651,10 @@ interface CSSMathMax : CSSMathValue ...@@ -651,12 +651,10 @@ interface CSSMathMax : CSSMathValue
attribute @@toStringTag attribute @@toStringTag
getter values getter values
method constructor method constructor
setter values
interface CSSMathMin : CSSMathValue interface CSSMathMin : CSSMathValue
attribute @@toStringTag attribute @@toStringTag
getter values getter values
method constructor method constructor
setter values
interface CSSMathNegate : CSSMathValue interface CSSMathNegate : CSSMathValue
attribute @@toStringTag attribute @@toStringTag
getter value getter value
...@@ -666,12 +664,10 @@ interface CSSMathProduct : CSSMathValue ...@@ -666,12 +664,10 @@ interface CSSMathProduct : CSSMathValue
attribute @@toStringTag attribute @@toStringTag
getter values getter values
method constructor method constructor
setter values
interface CSSMathSum : CSSMathValue interface CSSMathSum : CSSMathValue
attribute @@toStringTag attribute @@toStringTag
getter values getter values
method constructor method constructor
setter values
interface CSSMathValue : CSSNumericValue interface CSSMathValue : CSSNumericValue
attribute @@toStringTag attribute @@toStringTag
getter operator getter operator
......
...@@ -10,5 +10,5 @@ ...@@ -10,5 +10,5 @@
RaisesException=Constructor, RaisesException=Constructor,
RuntimeEnabled=CSSTypedOM RuntimeEnabled=CSSTypedOM
] interface CSSMathMax : CSSMathValue { ] interface CSSMathMax : CSSMathValue {
attribute CSSNumericArray values; readonly attribute CSSNumericArray values;
}; };
...@@ -10,5 +10,5 @@ ...@@ -10,5 +10,5 @@
RaisesException=Constructor, RaisesException=Constructor,
RuntimeEnabled=CSSTypedOM RuntimeEnabled=CSSTypedOM
] interface CSSMathMin : CSSMathValue { ] interface CSSMathMin : CSSMathValue {
attribute CSSNumericArray values; readonly attribute CSSNumericArray values;
}; };
...@@ -10,5 +10,5 @@ ...@@ -10,5 +10,5 @@
RaisesException=Constructor, RaisesException=Constructor,
RuntimeEnabled=CSSTypedOM RuntimeEnabled=CSSTypedOM
] interface CSSMathProduct : CSSMathValue { ] interface CSSMathProduct : CSSMathValue {
attribute CSSNumericArray values; readonly attribute CSSNumericArray values;
}; };
...@@ -10,5 +10,5 @@ ...@@ -10,5 +10,5 @@
RaisesException=Constructor, RaisesException=Constructor,
RuntimeEnabled=CSSTypedOM RuntimeEnabled=CSSTypedOM
] interface CSSMathSum : CSSMathValue { ] interface CSSMathSum : CSSMathValue {
attribute CSSNumericArray values; readonly attribute CSSNumericArray values;
}; };
...@@ -16,7 +16,6 @@ class CORE_EXPORT CSSMathVariadic : public CSSMathValue { ...@@ -16,7 +16,6 @@ class CORE_EXPORT CSSMathVariadic : public CSSMathValue {
public: public:
CSSNumericArray* values() { return values_.Get(); } CSSNumericArray* values() { return values_.Get(); }
void setValues(CSSNumericArray* values) { values_ = values; }
const CSSNumericValueVector& NumericValues() const { const CSSNumericValueVector& NumericValues() const {
return values_->Values(); return values_->Values();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment