Commit 37cfa2aa authored by apatrick@chromium.org's avatar apatrick@chromium.org

Revert 152040 - GPU process exits with error code on failure to initialize.

I think exiting with no error is counted as a GPU process crash for crash stats purposes.

Review URL: https://chromiumcodereview.appspot.com/10823375

TBR=apatrick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152380 0039d316-1c4b-4281-b951-d872f2087c98
parent e8476c99
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
#include "content/gpu/gpu_watchdog_thread.h" #include "content/gpu/gpu_watchdog_thread.h"
#include "content/public/common/content_client.h" #include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h" #include "content/public/common/content_switches.h"
#include "content/public/common/result_codes.h"
#include "ipc/ipc_channel_handle.h" #include "ipc/ipc_channel_handle.h"
#include "ipc/ipc_sync_message_filter.h" #include "ipc/ipc_sync_message_filter.h"
#include "ui/gl/gl_implementation.h" #include "ui/gl/gl_implementation.h"
...@@ -117,12 +116,8 @@ bool GpuChildThread::OnControlMessageReceived(const IPC::Message& msg) { ...@@ -117,12 +116,8 @@ bool GpuChildThread::OnControlMessageReceived(const IPC::Message& msg) {
void GpuChildThread::OnInitialize() { void GpuChildThread::OnInitialize() {
if (dead_on_arrival_) { if (dead_on_arrival_) {
VLOG(1) << "Exiting GPU process due to errors during initialization"; VLOG(1) << "Exiting GPU process due to errors during initialization";
MessageLoop::current()->Quit();
// Exit with the exit code that would be returned if the GPU process was return;
// killed using task mamager so that it does not count as a crash.
// TODO(apatrick): this is temporary to see if this impacts the crash
// statistics. If it does then the crash accounting should be fixed.
exit(content::RESULT_CODE_KILLED);
} }
// We don't need to pipe log messages if we are running the GPU thread in // We don't need to pipe log messages if we are running the GPU thread in
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment