Commit 37f6edb3 authored by jochen@chromium.org's avatar jochen@chromium.org

Revert 245489 "make utf-8 default encoding for remoting_localize.py"

Broke compilation on windows clobber builder: mc : error : -u switch cannot be used with non-Unicode message file!

> make utf-8 default encoding for remoting_localize.py
> 
> Review URL: https://codereview.chromium.org/140793007

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/141003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245500 0039d316-1c4b-4281-b951-d872f2087c98
parent 0ea8a6b9
...@@ -805,6 +805,7 @@ ...@@ -805,6 +805,7 @@
'--template', 'host/plugin/host_plugin-InfoPlist.strings.jinja2', '--template', 'host/plugin/host_plugin-InfoPlist.strings.jinja2',
'--locale_output', '--locale_output',
'<(SHARED_INTERMEDIATE_DIR)/remoting/host_plugin_resources/@{json_suffix}.lproj/InfoPlist.strings', '<(SHARED_INTERMEDIATE_DIR)/remoting/host_plugin_resources/@{json_suffix}.lproj/InfoPlist.strings',
'--encoding', 'utf-8',
'<@(remoting_locales)', '<@(remoting_locales)',
], ],
}, },
...@@ -826,6 +827,7 @@ ...@@ -826,6 +827,7 @@
'--template', 'host/remoting_me2me_host-InfoPlist.strings.jinja2', '--template', 'host/remoting_me2me_host-InfoPlist.strings.jinja2',
'--locale_output', '--locale_output',
'<(SHARED_INTERMEDIATE_DIR)/remoting/host_resources/@{json_suffix}.lproj/InfoPlist.strings', '<(SHARED_INTERMEDIATE_DIR)/remoting/host_resources/@{json_suffix}.lproj/InfoPlist.strings',
'--encoding', 'utf-8',
'<@(remoting_locales)', '<@(remoting_locales)',
], ],
}, },
...@@ -847,6 +849,7 @@ ...@@ -847,6 +849,7 @@
'--template', 'host/mac/me2me_preference_pane-InfoPlist.strings.jinja2', '--template', 'host/mac/me2me_preference_pane-InfoPlist.strings.jinja2',
'--locale_output', '--locale_output',
'<(SHARED_INTERMEDIATE_DIR)/remoting/preference_pane_resources/@{json_suffix}.lproj/InfoPlist.strings', '<(SHARED_INTERMEDIATE_DIR)/remoting/preference_pane_resources/@{json_suffix}.lproj/InfoPlist.strings',
'--encoding', 'utf-8',
'<@(remoting_locales)', '<@(remoting_locales)',
], ],
}, },
...@@ -868,6 +871,7 @@ ...@@ -868,6 +871,7 @@
'--template', 'host/installer/mac/uninstaller/remoting_uninstaller-InfoPlist.strings.jinja2', '--template', 'host/installer/mac/uninstaller/remoting_uninstaller-InfoPlist.strings.jinja2',
'--locale_output', '--locale_output',
'<(SHARED_INTERMEDIATE_DIR)/remoting/uninstaller_resources/@{json_suffix}.lproj/InfoPlist.strings', '<(SHARED_INTERMEDIATE_DIR)/remoting/uninstaller_resources/@{json_suffix}.lproj/InfoPlist.strings',
'--encoding', 'utf-8',
'<@(remoting_locales)', '<@(remoting_locales)',
], ],
}, },
...@@ -1638,7 +1642,6 @@ ...@@ -1638,7 +1642,6 @@
'--locale_dir', '<(webapp_locale_dir)', '--locale_dir', '<(webapp_locale_dir)',
'--template', '<(RULE_INPUT_PATH)', '--template', '<(RULE_INPUT_PATH)',
'--output', '<@(_outputs)', '--output', '<@(_outputs)',
'--encoding', 'utf-16',
'<@(remoting_locales)', '<@(remoting_locales)',
], ],
'message': 'Localizing the dialogs and strings' 'message': 'Localizing the dialogs and strings'
...@@ -2262,6 +2265,7 @@ ...@@ -2262,6 +2265,7 @@
'--template', '<(input)', '--template', '<(input)',
'--locale_output', '--locale_output',
'<(output)', '<(output)',
'--encoding', 'utf-8',
'en', 'en',
], ],
}, },
......
...@@ -590,7 +590,7 @@ def ReadMessagesFromFile(file_name): ...@@ -590,7 +590,7 @@ def ReadMessagesFromFile(file_name):
return values return values
def WriteIfChanged(file_name, contents, encoding): def WriteIfChanged(file_name, contents, encoding='utf-16'):
""" """
Writes the specified contents to the specified file_name Writes the specified contents to the specified file_name
iff the contents are different than the current contents. iff the contents are different than the current contents.
...@@ -743,8 +743,8 @@ def DoMain(argv): ...@@ -743,8 +743,8 @@ def DoMain(argv):
'-d', '--define', dest='define', action='append', type='string', '-d', '--define', dest='define', action='append', type='string',
help='define a variable (NAME=VALUE).') help='define a variable (NAME=VALUE).')
parser.add_option( parser.add_option(
'--encoding', dest='encoding', type='string', default='utf-8', '--encoding', dest='encoding', type='string', default='utf-16',
help="set the encoding of <output>. 'utf-8' is the default.") help="set the encoding of <output>. 'utf-16' is the default.")
parser.add_option( parser.add_option(
'--jinja2', dest='jinja2', type='string', '--jinja2', dest='jinja2', type='string',
help="specifies path to the jinja2 library.") help="specifies path to the jinja2 library.")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment