Commit 37f72463 authored by Shakti Sahu's avatar Shakti Sahu Committed by Commit Bot

Content indexing : UI polish

This CL fixes text size to match more with NTP feed articles.
1 - The text size of prefetch and content indexing cards to 16sp
2 - The line height is set to 24dp

Bug: 1031798
Change-Id: I7ae77e48d230a0226ca3b0ed0d27acaa1cf313f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956532Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723257}
parent 72f47f02
...@@ -50,7 +50,7 @@ ...@@ -50,7 +50,7 @@
app:layout_row="3" app:layout_row="3"
app:layout_columnSpan="4" /> app:layout_columnSpan="4" />
<TextView <org.chromium.ui.widget.TextViewWithLeading
android:id="@+id/title" android:id="@+id/title"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
...@@ -58,12 +58,13 @@ ...@@ -58,12 +58,13 @@
android:minHeight="40dp" android:minHeight="40dp"
android:maxLines="2" android:maxLines="2"
android:ellipsize="end" android:ellipsize="end"
android:textAppearance="@style/TextAppearance.BlackBodyDefault" android:textAppearance="@style/TextAppearance.BlackTitle1"
android:textAlignment="viewStart" android:textAlignment="viewStart"
app:leading="@dimen/text_size_large_leading"
app:layout_column="1" app:layout_column="1"
app:layout_row="0" app:layout_row="0"
app:layout_columnSpan="2" app:layout_columnSpan="2"
app:layout_gravity="fill_horizontal" /> app:layout_gravity="fill_horizontal"/>
<TextView <TextView
android:id="@+id/caption" android:id="@+id/caption"
...@@ -106,11 +107,11 @@ ...@@ -106,11 +107,11 @@
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
<include layout="@layout/list_menu_button" <include layout="@layout/list_menu_button"
android:layout_width="48dp" android:layout_width="48dp"
android:layout_height="48dp" android:layout_height="48dp"
android:paddingTop="12dp" android:paddingTop="12dp"
app:layout_column="3" app:layout_column="3"
app:layout_row="0" /> app:layout_row="0" />
<!-- Wrap this in a FrameLayout so that if the thumbnail is hidden this view <!-- Wrap this in a FrameLayout so that if the thumbnail is hidden this view
does not negatively affect layout. The FrameLayout spans the whole does not negatively affect layout. The FrameLayout spans the whole
...@@ -127,4 +128,4 @@ ...@@ -127,4 +128,4 @@
android:id="@+id/selection" android:id="@+id/selection"
style="@style/DownloadItemSelectionView"/> style="@style/DownloadItemSelectionView"/>
</FrameLayout> </FrameLayout>
</android.support.v7.widget.GridLayout> </android.support.v7.widget.GridLayout>
\ No newline at end of file
...@@ -40,7 +40,7 @@ ...@@ -40,7 +40,7 @@
android:layout_marginTop="-12dp" android:layout_marginTop="-12dp"
android:layout_alignParentEnd="true" /> android:layout_alignParentEnd="true" />
<TextView <org.chromium.ui.widget.TextViewWithLeading
android:id="@+id/title" android:id="@+id/title"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
...@@ -48,11 +48,12 @@ ...@@ -48,11 +48,12 @@
android:layout_toStartOf="@+id/more" android:layout_toStartOf="@+id/more"
android:layout_marginStart="16dp" android:layout_marginStart="16dp"
android:layout_alignTop="@id/thumbnail" android:layout_alignTop="@id/thumbnail"
android:maxLines="3" android:maxLines="2"
android:ellipsize="end" android:ellipsize="end"
android:textAppearance="@style/TextAppearance.BlackBodyDefault" android:textAppearance="@style/TextAppearance.BlackTitle1"
android:textAlignment="viewStart" android:textAlignment="viewStart"
app:layout_gravity="fill_horizontal" /> app:leading="@dimen/text_size_large_leading"
app:layout_gravity="fill_horizontal"/>
<TextView <TextView
android:id="@+id/timestamp" android:id="@+id/timestamp"
...@@ -60,7 +61,7 @@ ...@@ -60,7 +61,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_below="@id/title" android:layout_below="@id/title"
android:layout_alignStart="@id/title" android:layout_alignStart="@id/title"
android:layout_marginTop="16dp" android:layout_marginTop="10dp"
android:maxLines="1" android:maxLines="1"
android:ellipsize="end" android:ellipsize="end"
android:textAppearance="@style/TextAppearance.BlackCaption" android:textAppearance="@style/TextAppearance.BlackCaption"
...@@ -80,4 +81,4 @@ ...@@ -80,4 +81,4 @@
android:layout_marginTop="8dp" android:layout_marginTop="8dp"
android:layout_marginStart="8dp"/> android:layout_marginStart="8dp"/>
</FrameLayout> </FrameLayout>
</RelativeLayout> </RelativeLayout>
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment