Skip to content

GitLab

T
tangled
Commit 37fc90e8 authored by Thomas Guilbert's avatar Thomas Guilbert Committed by Chromium LUCI CQ
Browse files
Options

Re-enable video-zoom tests 

This CL [1] used video.requestVideoFrameCallback() to deflake tests.
crbug.com/1084265 fixed flakiness issues when capturing video frames at
the end of a test. The combination of the two means that some tests
that are marked as flaky could potentially be re-enabled.

This CL enables theses tests, and also updates
video-zoom-contols.html to use video.rVFC.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2208866

Bug: 636239, 988248, 1082837
Change-Id: I2c1fc2d481ba95fac7232f0050386eac9c13726c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556443
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832151}
parent 80aa2c7a
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 21 deletions
third_party/blink/web_tests/TestExpectations
View file @ 37fc90e8
...@@ -1742,8 +1742,6 @@ crbug.com/492664 [ Mac ] external/wpt/css/css-writing-modes/sizing-orthog-htb-in ...@@ -1742,8 +1742,6 @@ crbug.com/492664 [ Mac ] external/wpt/css/css-writing-modes/sizing-orthog-htb-in
crbug.com/381684 [ Mac ] fonts/family-fallback-gardiner.html [ Skip ] crbug.com/381684 [ Mac ] fonts/family-fallback-gardiner.html [ Skip ]
crbug.com/381684 [ Win ] fonts/family-fallback-gardiner.html [ Skip ] crbug.com/381684 [ Win ] fonts/family-fallback-gardiner.html [ Skip ]
crbug.com/636239 [ Win7 ] media/video-zoom-controls.html [ Failure ]
crbug.com/377696 printing/setPrinting.html [ Failure ] crbug.com/377696 printing/setPrinting.html [ Failure ]
# No support for WPT print-reftests: # No support for WPT print-reftests:
...@@ -5146,13 +5144,6 @@ crbug.com/993671 [ Win ] http/tests/media/video-frame-size-change.html [ Pass Fa ...@@ -5146,13 +5144,6 @@ crbug.com/993671 [ Win ] http/tests/media/video-frame-size-change.html [ Pass Fa
crbug.com/994692 [ Linux ] compositing/reflections/nested-reflection-anchor-point.html [ Pass Failure ] crbug.com/994692 [ Linux ] compositing/reflections/nested-reflection-anchor-point.html [ Pass Failure ]
crbug.com/994692 [ Win ] compositing/reflections/nested-reflection-anchor-point.html [ Pass Failure ] crbug.com/994692 [ Win ] compositing/reflections/nested-reflection-anchor-point.html [ Pass Failure ]
# Video flakily not being being rendered on Mac
crbug.com/988248 media/controls/captions-menu-always-visible.html [ Pass Failure ]
crbug.com/988248 [ Mac ] media/controls/overflow-menu-always-visible.html [ Pass Failure ]
crbug.com/988248 [ Mac ] media/video-persistence.html [ Pass Failure ]
crbug.com/988248 [ Linux ] media/video-persistence.html [ Pass Failure ]
crbug.com/988248 [ Mac ] media/video-zoom.html [ Pass Failure ]
crbug.com/996219 [ Win ] virtual/text-antialias/emoji-vertical-origin-visual.html [ Failure ] crbug.com/996219 [ Win ] virtual/text-antialias/emoji-vertical-origin-visual.html [ Failure ]
# Sheriff 2019-08-22 # Sheriff 2019-08-22
......
third_party/blink/web_tests/media/video-zoom-controls.html
View file @ 37fc90e8
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
<script src="video-paint-test.js"></script> <script src="video-paint-test.js"></script>
<script src="media-controls.js"></script> <script src="media-controls.js"></script>
</head> </head>
<body onload="setSrcByTagName('video', 'content/test.ogv'); init()"> <body onload="setVideoSrcAndWaitForFirstFrame('content/test.ogv');">
<p>Zoomed video with controls.</p> <p>Zoomed video with controls.</p>
<video width="160" height="120" controls></video> <video width="160" height="120" controls></video>
<video class="rotated" width="160" height="120" controls></video> <video class="rotated" width="160" height="120" controls></video>
......
third_party/blink/web_tests/media/video-zoom.html
View file @ 37fc90e8
...@@ -3,25 +3,16 @@ ...@@ -3,25 +3,16 @@
<style> video { zoom: 150%; border: 3px solid red; } </style> <style> video { zoom: 150%; border: 3px solid red; } </style>
<script src=media-file.js></script> <script src=media-file.js></script>
<script> <script>
function waitForVideoPresentation(video) {
return new Promise(resolve => {
video.requestVideoFrameCallback(resolve);
});
}
function init() function init()
{ {
var videosPresented = allVideosPresentedPromise();
setSrcByTagName("video", "content/test.ogv"); setSrcByTagName("video", "content/test.ogv");
if (!window.testRunner) if (!window.testRunner)
return; return;
testRunner.waitUntilDone(); testRunner.waitUntilDone();
let videos = Array.from(document.getElementsByTagName('video')); videosPresented.then(() => testRunner.notifyDone());
Promise.all(videos.map(
video => waitForVideoPresentation(video))).then(() => {
testRunner.notifyDone();
});
} }
</script> </script>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment