Commit 37fc9665 authored by meacer's avatar meacer Committed by Commit Bot

Remove unused histogram from external protocol dialog

This CL removes clickjacking.launch_url which was added back in 2009.
I suspect nobody is actively looking at it, so it seems safe to delete.

Change-Id: I088c115e2811c18a993385d86ca44a58ed449da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873110Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709110}
parent 98ec252a
......@@ -6,7 +6,6 @@
#include <utility>
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_util.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
#include "chrome/browser/profiles/profile.h"
......@@ -90,12 +89,6 @@ bool ExternalProtocolDialog::Cancel() {
}
bool ExternalProtocolDialog::Accept() {
// We record how long it takes the user to accept an external protocol. If
// users start accepting these dialogs too quickly, we should worry about
// clickjacking.
UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
base::TimeTicks::Now() - creation_time_);
const bool remember = message_box_view_->IsCheckBoxSelected();
ExternalProtocolHandler::RecordHandleStateMetrics(
remember, ExternalProtocolHandler::DONT_BLOCK);
......@@ -145,8 +138,7 @@ ExternalProtocolDialog::ExternalProtocolDialog(
: content::WebContentsObserver(web_contents),
url_(url),
program_name_(program_name),
initiating_origin_(initiating_origin),
creation_time_(base::TimeTicks::Now()) {
initiating_origin_(initiating_origin) {
DialogDelegate::set_default_button(ui::DIALOG_BUTTON_CANCEL);
DialogDelegate::set_button_label(
ui::DIALOG_BUTTON_OK,
......
......@@ -6,7 +6,6 @@
#define CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_
#include "base/macros.h"
#include "base/time/time.h"
#include "content/public/browser/web_contents_observer.h"
#include "ui/views/window/dialog_delegate.h"
#include "url/gurl.h"
......@@ -57,9 +56,6 @@ class ExternalProtocolDialog : public views::DialogDelegateView,
// The message box whose commands we handle.
views::MessageBoxView* message_box_view_;
// The time at which this dialog was created.
base::TimeTicks creation_time_;
DISALLOW_COPY_AND_ASSIGN(ExternalProtocolDialog);
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment