[Extensions] Add unpacked location type for extension features

This CL adds a new "unpacked" value which could be specied under the
"location" key for extension features. APIs/events specified as
"unpacked" will only be available for unpacked and command line
extensions.

This change was motivated by the
declarativeNetRequest.OnRuleMatchedDebug event which should only be
available for unpacked extensions.

Bug: 1017934
Change-Id: Iafe0a64160dc4ca083bcf58393aba94a87bfd3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892212
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711807}

chrome/common/extensions/api/_features.md

@@ -253,8 +253,8 @@ Accepted values are lists of strings from `extension`, `hosted_app`,
 The `location` property specifies the required install location of the
 extension.
 
-Accepted values are a single string from `component`, `external_component`, and
-`policy`.
+Accepted values are a single string from `component`, `external_component`,
+`policy`, and `unpacked`.
 
 ### internal
 

extensions/common/features/simple_feature.cc

@@ -456,6 +456,8 @@ bool SimpleFeature::MatchesManifestLocation(
     case SimpleFeature::POLICY_LOCATION:
       return manifest_location == Manifest::EXTERNAL_POLICY ||
              manifest_location == Manifest::EXTERNAL_POLICY_DOWNLOAD;
+    case SimpleFeature::UNPACKED_LOCATION:
+      return Manifest::IsUnpackedLocation(manifest_location);
   }
   NOTREACHED();
   return false;

extensions/common/features/simple_feature.h

@@ -90,6 +90,7 @@ class SimpleFeature : public Feature {
     COMPONENT_LOCATION,
     EXTERNAL_COMPONENT_LOCATION,
     POLICY_LOCATION,
+    UNPACKED_LOCATION,
   };
 
   // Setters used by generated code to create the feature.

extensions/common/features/simple_feature_unittest.cc

@@ -549,6 +549,8 @@ TEST_F(SimpleFeatureTest, Location) {
                                   Manifest::COMPONENT));
   EXPECT_TRUE(
       LocationIsAvailable(SimpleFeature::POLICY_LOCATION, Manifest::COMPONENT));
+  EXPECT_TRUE(LocationIsAvailable(SimpleFeature::UNPACKED_LOCATION,
+                                  Manifest::COMPONENT));
 
   // Only component extensions can access the "component" location.
   EXPECT_FALSE(LocationIsAvailable(SimpleFeature::COMPONENT_LOCATION,
@@ -584,6 +586,15 @@ TEST_F(SimpleFeatureTest, Location) {
   // location.
   EXPECT_TRUE(LocationIsAvailable(SimpleFeature::EXTERNAL_COMPONENT_LOCATION,
                                   Manifest::EXTERNAL_COMPONENT));
+
+  // Only unpacked and command line extensions can access the "unpacked"
+  // location.
+  EXPECT_TRUE(LocationIsAvailable(SimpleFeature::UNPACKED_LOCATION,
+                                  Manifest::UNPACKED));
+  EXPECT_TRUE(LocationIsAvailable(SimpleFeature::UNPACKED_LOCATION,
+                                  Manifest::COMMAND_LINE));
+  EXPECT_FALSE(LocationIsAvailable(SimpleFeature::UNPACKED_LOCATION,
+                                   Manifest::INTERNAL));
 }
 
 TEST_F(SimpleFeatureTest, Platform) {

tools/json_schema_compiler/feature_compiler.py

@@ -194,6 +194,7 @@ FEATURE_GRAMMAR = (
           'component': 'SimpleFeature::COMPONENT_LOCATION',
           'external_component': 'SimpleFeature::EXTERNAL_COMPONENT_LOCATION',
           'policy': 'SimpleFeature::POLICY_LOCATION',
+          'unpacked': 'SimpleFeature::UNPACKED_LOCATION',
         }
       }
     },