Commit 380b367b authored by iclelland's avatar iclelland Committed by Commit bot

Disable several AutofillInteractive tests on ChromeOS

Several tests have been timing out more or less consistently on ChromeOS.
Occasionally, they time out four times in a row, and escalate to an actual
failure in the builder. This patch disables the most recent offenders:

AutofillInteractiveTest.OnInputAfterAutofill
AutofillInteractiveTest.DisableAutocompleteWhileFilling
AutofillInteractiveTest.InputFiresBeforeChange
AutofillInteractiveTest.NoAutofillForReadOnlyFields
AutofillInteractiveTest.AutofillFormWithRepeatedField
AutofillInteractiveTest.BasicFormFill

TBR=mathp@chromium.org
BUG=585885

Review URL: https://codereview.chromium.org/1683273002

Cr-Commit-Position: refs/heads/master@{#374715}
parent dbac2c6a
...@@ -469,7 +469,13 @@ class AutofillInteractiveTest : public InProcessBrowserTest { ...@@ -469,7 +469,13 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
}; };
// Test that basic form fill is working. // Test that basic form fill is working.
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, BasicFormFill) { // Flakily times out on ChromeOS http://crbug.com/585885
#if defined(OS_CHROMEOS)
#define MAYBE_BasicFormFill DISABLED_BasicFormFill
#else
#define MAYBE_BasicFormFill BasicFormFill
#endif
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_BasicFormFill) {
CreateTestProfile(); CreateTestProfile();
// Load the test page. // Load the test page.
...@@ -686,7 +692,13 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, ...@@ -686,7 +692,13 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
} }
// Test that a JavaScript oninput event is fired after auto-filling a form. // Test that a JavaScript oninput event is fired after auto-filling a form.
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, OnInputAfterAutofill) { // Flakily times out on ChromeOS http://crbug.com/585885
#if defined(OS_CHROMEOS)
#define MAYBE_OnInputAfterAutofill DISABLED_OnInputAfterAutofill
#else
#define MAYBE_OnInputAfterAutofill OnInputAfterAutofill
#endif
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_OnInputAfterAutofill) {
CreateTestProfile(); CreateTestProfile();
const char kOnInputScript[] = const char kOnInputScript[] =
...@@ -835,7 +847,13 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_OnChangeAfterAutofill) { ...@@ -835,7 +847,13 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_OnChangeAfterAutofill) {
EXPECT_FALSE(unchanged_select_fired); EXPECT_FALSE(unchanged_select_fired);
} }
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, InputFiresBeforeChange) { // Flakily times out on ChromeOS http://crbug.com/585885
#if defined(OS_CHROMEOS)
#define MAYBE_InputFiresBeforeChange DISABLED_InputFiresBeforeChange
#else
#define MAYBE_InputFiresBeforeChange InputFiresBeforeChange
#endif
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_InputFiresBeforeChange) {
CreateTestProfile(); CreateTestProfile();
const char kInputFiresBeforeChangeScript[] = const char kInputFiresBeforeChangeScript[] =
...@@ -946,7 +964,15 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, ...@@ -946,7 +964,15 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
// In the wild, the repeated fields are typically either email fields // In the wild, the repeated fields are typically either email fields
// (duplicated for "confirmation"); or variants that are hot-swapped via // (duplicated for "confirmation"); or variants that are hot-swapped via
// JavaScript, with only one actually visible at any given time. // JavaScript, with only one actually visible at any given time.
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, AutofillFormWithRepeatedField) { // Flakily times out on ChromeOS http://crbug.com/585885
#if defined(OS_CHROMEOS)
#define MAYBE_AutofillFormWithRepeatedField \
DISABLED_AutofillFormWithRepeatedField
#else
#define MAYBE_AutofillFormWithRepeatedField AutofillFormWithRepeatedField
#endif
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
MAYBE_AutofillFormWithRepeatedField) {
CreateTestProfile(); CreateTestProfile();
// Load the test page. // Load the test page.
...@@ -1276,11 +1302,12 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_ComparePhoneNumbers) { ...@@ -1276,11 +1302,12 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, MAYBE_ComparePhoneNumbers) {
// Test that Autofill does not fill in read-only fields. // Test that Autofill does not fill in read-only fields.
// Flaky on the official cros-trunk. crbug.com/516052 // Flaky on the official cros-trunk. crbug.com/516052
#if defined(OFFICIAL_BUILD) // Also flaky on ChromiumOS generally. crbug.com/585885
#if defined(OFFICIAL_BUILD) || defined(OS_CHROMEOS)
#define MAYBE_NoAutofillForReadOnlyFields DISABLED_NoAutofillForReadOnlyFields #define MAYBE_NoAutofillForReadOnlyFields DISABLED_NoAutofillForReadOnlyFields
#else #else
#define MAYBE_NoAutofillForReadOnlyFields NoAutofillForReadOnlyFields #define MAYBE_NoAutofillForReadOnlyFields NoAutofillForReadOnlyFields
#endif // defined(OFFICIAL_BUILD) #endif // defined(OFFICIAL_BUILD) || defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
MAYBE_NoAutofillForReadOnlyFields) { MAYBE_NoAutofillForReadOnlyFields) {
std::string addr_line1("1234 H St."); std::string addr_line1("1234 H St.");
...@@ -1440,8 +1467,15 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, ...@@ -1440,8 +1467,15 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
// Test that Chrome doesn't crash when autocomplete is disabled while the user // Test that Chrome doesn't crash when autocomplete is disabled while the user
// is interacting with the form. This is a regression test for // is interacting with the form. This is a regression test for
// http://crbug.com/160476 // http://crbug.com/160476
// Flakily times out on ChromeOS http://crbug.com/585885
#if defined(OS_CHROMEOS)
#define MAYBE_DisableAutocompleteWhileFilling \
DISABLED_DisableAutocompleteWhileFilling
#else
#define MAYBE_DisableAutocompleteWhileFilling DisableAutocompleteWhileFilling
#endif
IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
DisableAutocompleteWhileFilling) { MAYBE_DisableAutocompleteWhileFilling) {
CreateTestProfile(); CreateTestProfile();
// Load the test page. // Load the test page.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment