[ChromeDriver] Remove LaunchApp from an extension test

Modify ChromeExtensionsCapabilityTest.testCanInspectBackgroundPage
to stop using obsolete LaunchApp API.

Bug: chromedriver:2278
Change-Id: Ided03a33e59ee2251e47550f9b6ae0d8b96f3f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053172
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741545}

chrome/test/chromedriver/test/run_py_tests.py

@@ -143,11 +143,6 @@ _INTEGRATION_NEGATIVE_FILTER = [
     'ChromeDriverTest.testWindowMaximize',
     # LaunchApp is an obsolete API.
     'ChromeExtensionsCapabilityTest.testCanLaunchApp',
-    # https://bugs.chromium.org/p/chromedriver/issues/detail?id=2278
-    # The following test uses the obsolete LaunchApp API, and is thus excluded.
-    # TODO(johnchen@chromium.org): Investigate feasibility of re-writing the
-    # test case without using LaunchApp.
-    'ChromeExtensionsCapabilityTest.testCanInspectBackgroundPage',
     # PerfTest takes a long time, requires extra setup, and adds little value
     # to integration testing.
     'PerfTest.*',
@@ -3532,23 +3527,18 @@ class ChromeExtensionsCapabilityTest(ChromeDriverBaseTestWithWebServer):
     self.assertEqual('It works!', body_element.GetText())
 
   def testCanInspectBackgroundPage(self):
-    app_path = os.path.join(_TEST_DATA_DIR, 'test_app')
-    extension_path = os.path.join(_TEST_DATA_DIR, 'all_frames')
+    crx = os.path.join(_TEST_DATA_DIR, 'ext_bg_page.crx')
     driver = self.CreateDriver(
-        chrome_switches=['load-extension=%s' % app_path],
+        chrome_extensions=[self._PackExtension(crx)],
         experimental_options={'windowTypes': ['background_page']})
-    old_handles = driver.GetWindowHandles()
-    driver.LaunchApp('gegjcdcfeiojglhifpmibkadodekakpc')
-    new_window_handle = self.WaitForNewWindow(
-        driver, old_handles, check_closed_windows=False)
     handles = driver.GetWindowHandles()
     for handle in handles:
       driver.SwitchToWindow(handle)
       if driver.GetCurrentUrl() == 'chrome-extension://' \
-          'gegjcdcfeiojglhifpmibkadodekakpc/_generated_background_page.html':
+          'nibbphkelpaohebejnbojjalikodckih/_generated_background_page.html':
         self.assertEqual(42, driver.ExecuteScript('return magic;'))
         return
-    self.fail("couldn't find generated background page for test app")
+    self.fail("couldn't find generated background page for test extension")
 
   def testIFrameWithExtensionsSource(self):
     crx_path = os.path.join(_TEST_DATA_DIR, 'frames_extension.crx')

chrome/test/data/chromedriver/ext_bg_page.pem

+-----BEGIN PRIVATE KEY-----
+MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQCppJ54END19d9O
+IbHOchCMsz9KvcQb2S9Co3f/nKxX5KNDWYezdfzzUAqYnvF5Z5dRSsnFmlOJ61Cg
+WAYjl/kdVdr7H39D2Mtm5/k3HJ9tf7daT/wTj5b2gqVOb5ZkqgfjwBGvZzGLRtow
+GESh/aWiDp3wqOQyxN8AchkZVlEhmc+JfUNm4WG7gfeIA+vBgmRjZXZROnj3RlWr
+/ce8X2T3x38fmvCaXT43YA5hnXZrkMqozfrnroY10HKPgi3mVkquOwC/lUqjpy/K
+8R8xTj2/Nq4rh0kJLzAH3+Ih2RCkCpg/+Fo8irKHaTBLW7aJX+vXzW8PH17tOPmT
+CfvvnvV5AgMBAAECggEABfxQWJdsTg9itYqoD8sTxSkibbBQKfTh72Gd72uPY6sG
+LS9Mo9MBDbM4an3qMoDKlKRVRfb95VcDkWLFta4MLMItn7By8LmGpL8A2rZUdDw+
+Q44grG6Dsrc1nrS+e1cJ//nUDeqv03SYqHuEuWv+Ev+dyELnSVjLrwP3mX6jjnJE
+i5lXcVEQlFQSV4he2nwtPifZQAWoO28PV6W4DgV2JD83AZhioUyNBJgjgj6UOcy2
+7ygEhFiSJyOfc7H+3JGi6syFY+thNF52uNZnxJUziMalNBzhkZJI20C/UoK+ln5F
+SWX4M8Fav4KIO3u5wGTgJDKtJpgYmAvqowN9zPtl0QKBgQDWHWDzQV2v96yNBA5g
+tIlI9atiWRR9RvRQxfAdBgz3VwVDUtsNWBLMnx+ZcsSZZwuymkQblodyj5n9MKqZ
+N1b7/zsLQkNeNJkQfNL/AopZdkI97LoFhHo/FDKRlb2o5r9BH+0zoTWYf2YZoKfi
+GhVLdYx0sGUySAXSSwgLPpGd8QKBgQDK1CXUVDuQuvJHQc0QZsSwZFICKNfAzzCK
+awWFbp9aTNDf3Qkm5ThZap9ZsqAvDWku7rOI858rCnhuRw80ovxR3BtMAElCvsZD
+JDNJff6YjIXJko6xeKDM209CYC0NZwpLsIud+y+gXRadmurTd3S/SoNdV2EaLsSe
+QmOF1T7oCQKBgAKWaE2IRLGTtKofmmzgwaf4EBIoMW8yJFG1kqlHIXD7xDyEC9Gl
+dtSyN5eLI4UXEbUe2CPdNdXUlm/Q3r7rREnXU8dXDaldyVvBpmsehL2ACFznN3hJ
+mZCZleLchGY+I6GN2Tf+gr9NCtbUcjLxTcCTsxbV6uMoq6lW7snz/56BAoGAFp+f
+MJXMpxITIBuY0fGEkuA9vXvsxNbXZTkWvpFeOOZEjhPLh4kdxet8praj41utlcyO
+PgJeiKB8WmCWs5pSZpcUfF+zzDwXRTnudo4VLdLOwXMVc3ovBWqY5qBvpgUOQu8I
+Q7DW2R5I/X9gHgI/BW88Q9cRP6hjyftBupXUlHECgYEAqeDLFSHyzWgFdcOk5CUV
+yw1yLWYLty09fKwcFdca3drsA519oRUbUADE96faxQUbGASenox7bcCoT0893bW/
+qiknvZXeFgGounl79/2iIeHsq27hP4LP2napzg1KnZha5Owai1igNXroSXK8IHo5
+xN1i6LbH5IBqlHSQQpYR6ck=
+-----END PRIVATE KEY-----

chrome/test/data/chromedriver/ext_bg_page/background.js

+magic = 42;

chrome/test/data/chromedriver/ext_bg_page/manifest.json

+{
+  "name": "ExtBgPage",
+  "version": "1.0",
+  "description": "Chromedriver extension with background page",
+  "manifest_version": 2,
+  "background": {
+    "scripts": ["background.js"]
+  }
+}