Make sync/sign-in error notifications actionable on click.

Since there is only one button, clicking the notification will perform
the same action as the button per PM/designer decision.

BUG=393680
R=atwilson@chromium.org
TEST=manual

Review URL: https://codereview.chromium.org/395463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283438 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/signin/signin_error_notifier_ash.cc

@@ -62,6 +62,8 @@ class SigninNotificationDelegate : public NotificationDelegate {
   virtual ~SigninNotificationDelegate();
 
  private:
+  void FixSignIn();
+
   // Unique id of the notification.
   const std::string id_;
 
@@ -94,9 +96,22 @@ bool SigninNotificationDelegate::HasClickedListener() {
 }
 
 void SigninNotificationDelegate::Click() {
+  FixSignIn();
 }
 
 void SigninNotificationDelegate::ButtonClick(int button_index) {
+  FixSignIn();
+}
+
+std::string SigninNotificationDelegate::id() const {
+  return id_;
+}
+
+content::WebContents* SigninNotificationDelegate::GetWebContents() const {
+  return NULL;
+}
+
+void SigninNotificationDelegate::FixSignIn() {
 #if defined(OS_CHROMEOS)
   chrome::AttemptUserExit();
 #else
@@ -116,14 +131,6 @@ void SigninNotificationDelegate::ButtonClick(int button_index) {
 #endif
 }
 
-std::string SigninNotificationDelegate::id() const {
-  return id_;
-}
-
-content::WebContents* SigninNotificationDelegate::GetWebContents() const {
-  return NULL;
-}
-
 }  // namespace
 
 SigninErrorNotifier::SigninErrorNotifier(SigninErrorController* controller,

chrome/browser/sync/sync_error_notifier_ash.cc

@@ -57,6 +57,8 @@ class SyncNotificationDelegate : public NotificationDelegate {
   virtual ~SyncNotificationDelegate();
 
  private:
+  void ShowSyncSetup();
+
   // Unique id of the notification.
   const std::string id_;
 
@@ -89,6 +91,11 @@ bool SyncNotificationDelegate::HasClickedListener() {
 }
 
 void SyncNotificationDelegate::Click() {
+  ShowSyncSetup();
+}
+
+void SyncNotificationDelegate::ButtonClick(int button_index) {
+  ShowSyncSetup();
 }
 
 std::string SyncNotificationDelegate::id() const {
@@ -99,7 +106,7 @@ content::WebContents* SyncNotificationDelegate::GetWebContents() const {
   return NULL;
 }
 
-void SyncNotificationDelegate::ButtonClick(int button_index) {
+void SyncNotificationDelegate::ShowSyncSetup() {
   LoginUIService* login_ui = LoginUIServiceFactory::GetForProfile(profile_);
   if (login_ui->current_login_ui()) {
     // TODO(michaelpg): The LoginUI might be on an inactive desktop.