Commit 38262236 authored by Yasmin's avatar Yasmin Committed by Commit Bot

Update the shared clipboard label from "Send to" to "Send text to".

Before:
  One device: Send to pixel 2XL
  Multiple device: Send to devices

After:
  One device: https://screenshot.googleplex.com/h7ggmzB8TZz
  Multiple device: https://screenshot.googleplex.com/mduLZUSpqLb

Bug: 996676
Change-Id: I775de0d561859b21f5b8ebf6721aa19fcea005c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768591Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691115}
parent 94a00038
......@@ -6513,9 +6513,15 @@ the Bookmarks menu.">
<message name="IDS_CONTENT_CONTEXT_SHARING_CLICK_TO_CALL_MULTIPLE_DEVICES" desc="The label of item for click to call in context menu when multiple devices are available.">
Call from your devices
</message>
<message name="IDS_CONTENT_CONTEXT_SHARING_CLICK_TO_CALL_SINGLE_DEVICE" desc="The label of item for click to call in context menu for showing device name when multiple devices are available.">
<message name="IDS_CONTENT_CONTEXT_SHARING_CLICK_TO_CALL_SINGLE_DEVICE" desc="The label of item for click to call in context menu for showing device name when one device is available.">
Call from <ph name="DEVICE_NAME">$1<ex>Jimmy's Pixel</ex></ph>
</message>
<message name="IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_MULTIPLE_DEVICES" desc="The label of item for shared clipboard in context menu when multiple devices are available.">
Send text to your devices
</message>
<message name="IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_SINGLE_DEVICE" desc="The label of item for shared clipboard in context menu for showing device name when one device is available.">
Send text to <ph name="DEVICE_NAME">$1<ex>Jimmy's Pixel</ex></ph>
</message>
</if>
<if expr="use_titlecase">
......@@ -6525,6 +6531,12 @@ the Bookmarks menu.">
<message name="IDS_CONTENT_CONTEXT_SHARING_CLICK_TO_CALL_SINGLE_DEVICE" desc="In Title Case: The label of item for click to call in context menu when single device is available.">
Call from <ph name="DEVICE_NAME">$1<ex>Jimmy's Pixel</ex></ph>
</message>
<message name="IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_MULTIPLE_DEVICES" desc="In Title Case: The label of item for shared clipboard in context menu when multiple devices are available.">
Send text to Your Devices
</message>
<message name="IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_SINGLE_DEVICE" desc="In Title Case: The label of item for shared clipboard in context menu when single device is available.">
Send text to <ph name="DEVICE_NAME">$1<ex>Jimmy's Pixel</ex></ph>
</message>
</if>
......
......@@ -73,13 +73,13 @@ void SharedClipboardContextMenuObserver::InitMenu(
proxy_->AddMenuItem(
IDC_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_SINGLE_DEVICE,
l10n_util::GetStringFUTF16(
IDS_CONTEXT_MENU_SEND_TAB_TO_SELF_SINGLE_TARGET,
IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_SINGLE_DEVICE,
base::UTF8ToUTF16(devices[0]->client_name())));
#else
proxy_->AddMenuItemWithIcon(
IDC_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_SINGLE_DEVICE,
l10n_util::GetStringFUTF16(
IDS_CONTEXT_MENU_SEND_TAB_TO_SELF_SINGLE_TARGET,
IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_SINGLE_DEVICE,
base::UTF8ToUTF16(devices[0]->client_name())),
GetContextMenuIcon());
#endif
......@@ -88,13 +88,14 @@ void SharedClipboardContextMenuObserver::InitMenu(
#if defined(OS_MACOSX)
proxy_->AddSubMenu(
IDC_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_MULTIPLE_DEVICES,
l10n_util::GetStringUTF16(IDS_CONTEXT_MENU_SEND_TAB_TO_SELF),
l10n_util::GetStringUTF16(
IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_MULTIPLE_DEVICES),
sub_menu_model_.get());
#else
proxy_->AddSubMenuWithStringIdAndIcon(
IDC_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_MULTIPLE_DEVICES,
IDS_CONTEXT_MENU_SEND_TAB_TO_SELF, sub_menu_model_.get(),
GetContextMenuIcon());
IDS_CONTENT_CONTEXT_SHARING_SHARED_CLIPBOARD_MULTIPLE_DEVICES,
sub_menu_model_.get(), GetContextMenuIcon());
#endif
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment