[animation-worklet] Integrate AnimationWorklet with origin trial infra

Intent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AZ-PYPMS7EA/DEqbe2u5BQAJ Bug: 811922 Change-Id: I967df8e38d55cffc985ca8982f3762e95aa08ae7 Reviewed-on: https://chromium-review.googlesource.com/917125 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539299}

[animation-worklet] Integrate AnimationWorklet with origin trial infra
Intent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AZ-PYPMS7EA/DEqbe2u5BQAJ Bug: 811922 Change-Id: I967df8e38d55cffc985ca8982f3762e95aa08ae7 Reviewed-on: https://chromium-review.googlesource.com/917125 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539299}
384c9d45 · Majid Valipour · Commit Bot · 5c8f1b53 · 384c9d45 · 384c9d45
Commit 384c9d45 authored Feb 26, 2018 by Majid Valipour Committed by Commit Bot Feb 26, 2018
10 changed files
--- a/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
+++ b/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
+<!DOCTYPE html>
+<!-- Generate token with the command:
+generate_token.py http://127.0.0.1:8000 AnimationWorklet --expire-timestamp=2000000000
+-->
+<meta http-equiv="origin-trial" content="AnRfiFGg50a1+vvDBVfbBNiiRFBBQDy+3oMlJw2pUNRb8tPyN2XX0kAJxiA0itCLJTM0DrsIfVYuv4ni0Lu6bQgAAABYeyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR1cmUiOiAiQW5pbWF0aW9uV29ya2xldCIsICJleHBpcnkiOiAyMDAwMDAwMDAwfQ==" />
+<title>AnimationWorklet - interfaces exposed by origin trial</title>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../../resources/origin-trials-helper.js"></script>
+<script>
+test(t => {
+  OriginTrialsHelper.check_interfaces(this,
+      ['WorkletAnimation', 'ScrollTimeline']);
+}, 'AnimationWorklet related interfaces in Origin-Trial enabled document.');
+test(t => {
+  OriginTrialsHelper.check_properties(this,
+      {'global': ['animationWorklet'],
+       'WorkletAnimation': ['play', 'cancel', 'playState'],
+       'ScrollTimeline': ['scrollSource', 'orientation', 'timeRange'],
+      });
+}, 'AnimationWorklet related properties in Origin-Trial enabled document.');
+</script>
--- a/third_party/WebKit/Source/core/animation/ScrollTimeline.cpp
+++ b/third_party/WebKit/Source/core/animation/ScrollTimeline.cpp
@@ -57,7 +57,6 @@ ScrollTimeline::ScrollTimeline(const Document& document,
    : scroll_source_(scroll_source),
      orientation_(orientation),
      time_range_(time_range) {
-  DCHECK(RuntimeEnabledFeatures::AnimationWorkletEnabled());
 }
 double ScrollTimeline::currentTime(bool& is_null) {

--- a/third_party/WebKit/Source/core/animation/ScrollTimeline.idl
+++ b/third_party/WebKit/Source/core/animation/ScrollTimeline.idl
@@ -9,7 +9,7 @@
    ConstructorCallWith=Document,
    MeasureAs=ScrollTimelineConstructor,
    RaisesException=Constructor,
-    RuntimeEnabled=AnimationWorklet
+    OriginTrialEnabled=AnimationWorklet
 ] interface ScrollTimeline : AnimationTimeline {
    readonly attribute Element? scrollSource;
    readonly attribute ScrollDirection orientation;

--- a/third_party/WebKit/Source/core/testing/InternalSettings.cpp
+++ b/third_party/WebKit/Source/core/testing/InternalSettings.cpp
@@ -79,9 +79,7 @@ InternalSettings::Backup::Backup(Settings* settings)
      default_video_poster_url_(settings->GetDefaultVideoPosterURL()),
      original_image_animation_policy_(settings->GetImageAnimationPolicy()),
      original_scroll_top_left_interop_enabled_(
-          RuntimeEnabledFeatures::ScrollTopLeftInteropEnabled()),
+          RuntimeEnabledFeatures::ScrollTopLeftInteropEnabled()) {}
-      original_animation_worklet_enabled_(
-          RuntimeEnabledFeatures::AnimationWorkletEnabled()) {}
 void InternalSettings::Backup::RestoreTo(Settings* settings) {
  RuntimeEnabledFeatures::SetExperimentalContentSecurityPolicyFeaturesEnabled(
@@ -505,13 +503,6 @@ void InternalSettings::SetPreloadLogging(bool enabled,
  GetSettings()->SetLogPreload(enabled);
 }
-void InternalSettings::setAnimationWorkletEnabled(
-    bool enabled,
-    ExceptionState& exception_state) {
-  InternalSettingsGuardForSettings();
-  RuntimeEnabledFeatures::SetAnimationWorkletEnabled(enabled);
-}
 void InternalSettings::setPresentationReceiver(
    bool enabled,
    ExceptionState& exception_state) {

--- a/third_party/WebKit/Source/core/testing/InternalSettings.h
+++ b/third_party/WebKit/Source/core/testing/InternalSettings.h
@@ -73,7 +73,6 @@ class InternalSettings final : public InternalSettingsGenerated,
    String default_video_poster_url_;
    ImageAnimationPolicy original_image_animation_policy_;
    bool original_scroll_top_left_interop_enabled_;
-    bool original_animation_worklet_enabled_;
  };
  static InternalSettings* Create(Page& page) {
@@ -125,7 +124,6 @@ class InternalSettings final : public InternalSettingsGenerated,
  void setViewportEnabled(bool, ExceptionState&);
  void setViewportMetaEnabled(bool, ExceptionState&);
  void setViewportStyle(const String& preference, ExceptionState&);
-  void setAnimationWorkletEnabled(bool, ExceptionState&);
  void setPresentationReceiver(bool, ExceptionState&);
  void setAutoplayPolicy(const String&, ExceptionState&);

--- a/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScope.idl
+++ b/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScope.idl
@@ -5,7 +5,7 @@
 [
    Exposed=AnimationWorklet,
    Global=(Worklet,AnimationWorklet),
-    RuntimeEnabled=AnimationWorklet
+    OriginTrialEnabled=AnimationWorklet
 ] interface AnimationWorkletGlobalScope : WorkletGlobalScope {
    [MeasureAs=AnimationWorkletRegisterAnimator, RaisesException] void registerAnimator(DOMString name, Function animatorConstructor);
 };
--- a/third_party/WebKit/Source/modules/animationworklet/EffectProxy.idl
+++ b/third_party/WebKit/Source/modules/animationworklet/EffectProxy.idl
@@ -7,7 +7,7 @@
 [
    Exposed=AnimationWorklet,
    Global=(AnimationWorklet),
-    RuntimeEnabled=AnimationWorklet
+    OriginTrialEnabled=AnimationWorklet
 ] interface EffectProxy {
  attribute unrestricted double localTime;
 };
\ No newline at end of file
--- a/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl
+++ b/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl
@@ -4,7 +4,7 @@
 [
    ImplementedAs=WindowAnimationWorklet,
-    RuntimeEnabled=AnimationWorklet,
+    OriginTrialEnabled=AnimationWorklet,
    SecureContext
 ] partial interface Window {
    readonly attribute Worklet animationWorklet;

--- a/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.idl
+++ b/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.idl
@@ -12,7 +12,7 @@
                SerializedScriptValue options),
    RaisesException=Constructor,
    MeasureAs=WorkletAnimationConstructor,
-    RuntimeEnabled=AnimationWorklet
+    OriginTrialEnabled=AnimationWorklet
 ] interface WorkletAnimation {
  readonly attribute AnimationPlayState playState;
  void play();

--- a/third_party/WebKit/Source/platform/runtime_enabled_features.json5
+++ b/third_party/WebKit/Source/platform/runtime_enabled_features.json5
@@ -84,6 +84,7 @@
    },
    {
      name: "AnimationWorklet",
+      origin_trial_feature_name: "AnimationWorklet",
      status: "experimental",
    },
    {