Commit 387490b9 authored by Eric Willigers's avatar Eric Willigers Committed by Commit Bot

Desktop PWAs: Create fewer apps in WebAppBrowserTest.HasMinimalUiButtons

WebAppBrowserTest.HasMinimalUiButtons created an opened 5 PWAs.

It now only creates and opens 3 PWAs, to avoid flaky timeout failures.

Bug: 1034029
Change-Id: I9de602007f2f9648dc8dd1f1c5fd9f1c6f15d065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975375
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726301}
parent a3ab85bc
...@@ -76,8 +76,7 @@ IN_PROC_BROWSER_TEST_P(WebAppBrowserTest, AutoGeneratedUserThemeCrash) { ...@@ -76,8 +76,7 @@ IN_PROC_BROWSER_TEST_P(WebAppBrowserTest, AutoGeneratedUserThemeCrash) {
LaunchWebAppBrowser(app_id); LaunchWebAppBrowser(app_id);
} }
// Flaky. http://crbug.com/1034029 IN_PROC_BROWSER_TEST_P(WebAppBrowserTest, HasMinimalUiButtons) {
IN_PROC_BROWSER_TEST_P(WebAppBrowserTest, DISABLED_HasMinimalUiButtons) {
int index = 0; int index = 0;
auto has_buttons = [this, &index](DisplayMode display_mode, auto has_buttons = [this, &index](DisplayMode display_mode,
bool open_as_window) -> bool { bool open_as_window) -> bool {
...@@ -96,15 +95,10 @@ IN_PROC_BROWSER_TEST_P(WebAppBrowserTest, DISABLED_HasMinimalUiButtons) { ...@@ -96,15 +95,10 @@ IN_PROC_BROWSER_TEST_P(WebAppBrowserTest, DISABLED_HasMinimalUiButtons) {
return app_browser->app_controller()->HasMinimalUiButtons(); return app_browser->app_controller()->HasMinimalUiButtons();
}; };
EXPECT_TRUE(has_buttons(DisplayMode::kBrowser,
/*open_as_window=*/true));
EXPECT_TRUE(has_buttons(DisplayMode::kMinimalUi, EXPECT_TRUE(has_buttons(DisplayMode::kMinimalUi,
/*open_as_window=*/true)); /*open_as_window=*/true));
EXPECT_FALSE(has_buttons(DisplayMode::kStandalone, EXPECT_FALSE(has_buttons(DisplayMode::kStandalone,
/*open_as_window=*/true)); /*open_as_window=*/true));
EXPECT_FALSE(has_buttons(DisplayMode::kFullscreen,
/*open_as_window=*/true));
EXPECT_FALSE(has_buttons(DisplayMode::kMinimalUi, EXPECT_FALSE(has_buttons(DisplayMode::kMinimalUi,
/*open_as_window=*/false)); /*open_as_window=*/false));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment