Commit 38840b3b authored by Friedrich Horschig's avatar Friedrich Horschig Committed by Commit Bot

[Mfill Android] Improve announcement for keyboard accessory

(This is a modified reland of https://crrev.com/c/1793082)

The keyboard accessory was still using the old announcement. It would
shout "Passwords available" which isn't wrong since passwords fallbacks
are available but it is very imprecise, incomplete and misleading if the
accessory is filled with Address autofill suggestion.

Bug: 1005147
Change-Id: Ie31261aafef6665f8f256abb186cbb4a54fd2852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807243
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: default avatarIoana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697572}
parent d3adcc7e
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/keyboard_accessory" android:id="@+id/keyboard_accessory"
android:layout_gravity="start|bottom" android:layout_gravity="start|bottom"
android:contentDescription="@string/autofill_keyboard_accessory_content_description" android:contentDescription="@string/autofill_keyboard_accessory_modern_content_description"
android:scrollbars="none" android:scrollbars="none"
android:visibility="gone" android:visibility="gone"
android:orientation="vertical" android:orientation="vertical"
......
...@@ -103,9 +103,12 @@ ...@@ -103,9 +103,12 @@
</translations> </translations>
<release allow_pseudo="false" seq="1"> <release allow_pseudo="false" seq="1">
<messages fallback_to_english="true"> <messages fallback_to_english="true">
<message name="IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION" desc="The text announced by the screen reader when the autofill suggestions are shown."> <message name="IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION" desc="The text announced by the screen reader when the password suggestions are shown.">
Passwords available Passwords available
</message> </message>
<message name="IDS_AUTOFILL_KEYBOARD_ACCESSORY_MODERN_CONTENT_DESCRIPTION" desc="The text announced by the screen reader when the autofill suggestions and fallbacks are shown.">
Autofill suggestions available
</message>
<message name="IDS_KEYBOARD_ACCESSORY_SHEET_HIDE" desc="Description for the active icon button that closes an accessory sheet and brings back the keyboard."> <message name="IDS_KEYBOARD_ACCESSORY_SHEET_HIDE" desc="Description for the active icon button that closes an accessory sheet and brings back the keyboard.">
Show keyboard Show keyboard
</message> </message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment