Commit 388470da authored by Tommy C. Li's avatar Tommy C. Li Committed by Commit Bot

Omnibox: Query in Omnibox / Elisions - Page info bubble shows full URL.

After this CL, when the user opens the page info bubble (for instance
by clicking the lock icon), Chrome shows the full URL in the search bar.

This is a way for users to show the full underlying URL for both the
Steady State Elisions and Query in Omnibox features.

We are currently gating this behavior on the Query in Omnibox flag,
since it's still under active experimentation.

Bug: 874592
Change-Id: Icdb1b8ac79f6f8f3a90b9f82dcd838c5af6b767f
Reviewed-on: https://chromium-review.googlesource.com/c/1265497
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597335}
parent f8237034
......@@ -382,6 +382,14 @@ bool LocationBarView::ShowPageInfoDialog(WebContents* contents) {
contents, entry->GetVirtualURL(), security_info);
bubble->SetHighlightedButton(location_icon_view());
bubble->GetWidget()->Show();
// When the user opens the page info bubble, we also expose the full URL,
// temporarily disabling Steady State Elisions and Query in Omnibox.
// We are currently gating this behavior on the Query in Omnibox flag, since
// it's still under active experimentation.
if (base::FeatureList::IsEnabled(omnibox::kQueryInOmnibox))
omnibox_view()->model()->SetUserTextToURLForEditing();
return true;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment