Commit 38a0e3c7 authored by thestig@chromium.org's avatar thestig@chromium.org

Heapchecker: Add presubmit checks for suppressions.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3197014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57132 0039d316-1c4b-4281-b951-d872f2087c98
parent 8fc6448e
# Copyright (c) 2010 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details on the presubmit API built into gcl.
"""
def CheckChange(input_api, output_api):
"""Checks the memcheck suppressions files for bad data."""
errors = []
skip_next_line = False
func_re = input_api.re.compile('[a-z_.]+\(.+\)$')
for f, line_num, line in input_api.RightHandSideLines(lambda x:
x.LocalPath().endswith('.txt')):
line = line.lstrip()
if line.startswith('#') or not line:
continue
if skip_next_line:
skip_next_line = False
continue
if line == '{':
skip_next_line = True
continue
if (line.startswith('fun:') or line.startswith('obj:') or
line == 'Heapcheck:Leak' or line == '}' or
line == '...'):
continue
if func_re.match(line):
continue
errors.append('"%s" is probably wrong: %s line %s' % (line, f.LocalPath(),
line_num))
if errors:
return [output_api.PresubmitError('\n'.join(errors))]
return []
def CheckChangeOnUpload(input_api, output_api):
return CheckChange(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return CheckChange(input_api, output_api)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment