Commit 38bca25e authored by yasong's avatar yasong Committed by Commit Bot

Remove unnecessary local variable in CreateIterator().

Also add one comment.

No functional change.

This CL lands server change 162922389 by bnc.
This CL lands server change 162991254 by yasong.

BUG=488484

Change-Id: I33889d0895da9c7a322cb8a11e0da3e4e0697470
Reviewed-on: https://chromium-review.googlesource.com/591774Reviewed-by: default avatarBence Béky <bnc@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490760}
parent 7daedbc1
...@@ -35,6 +35,8 @@ class PriorityWriteSchedulerPeer; ...@@ -35,6 +35,8 @@ class PriorityWriteSchedulerPeer;
// for each priority value. Each PriorityInfo contains a list of streams of // for each priority value. Each PriorityInfo contains a list of streams of
// that priority that are ready to write, as well as a timestamp of the last // that priority that are ready to write, as well as a timestamp of the last
// I/O event that occurred for a stream of that priority. // I/O event that occurred for a stream of that priority.
//
// DO NOT USE. Deprecated.
template <typename StreamIdType> template <typename StreamIdType>
class PriorityWriteScheduler : public WriteScheduler<StreamIdType> { class PriorityWriteScheduler : public WriteScheduler<StreamIdType> {
public: public:
......
...@@ -417,30 +417,26 @@ const SpdyFrameIR& SpdyFramer::SpdyControlFrameIterator::GetIR() const { ...@@ -417,30 +417,26 @@ const SpdyFrameIR& SpdyFramer::SpdyControlFrameIterator::GetIR() const {
std::unique_ptr<SpdyFrameSequence> SpdyFramer::CreateIterator( std::unique_ptr<SpdyFrameSequence> SpdyFramer::CreateIterator(
SpdyFramer* framer, SpdyFramer* framer,
std::unique_ptr<const SpdyFrameIR> frame_ir) { std::unique_ptr<const SpdyFrameIR> frame_ir) {
std::unique_ptr<SpdyFrameSequence> result = nullptr;
switch (frame_ir->frame_type()) { switch (frame_ir->frame_type()) {
case SpdyFrameType::HEADERS: { case SpdyFrameType::HEADERS: {
result = SpdyMakeUnique<SpdyHeaderFrameIterator>( return SpdyMakeUnique<SpdyHeaderFrameIterator>(
framer, SpdyWrapUnique( framer, SpdyWrapUnique(
static_cast<const SpdyHeadersIR*>(frame_ir.release()))); static_cast<const SpdyHeadersIR*>(frame_ir.release())));
break;
} }
case SpdyFrameType::PUSH_PROMISE: { case SpdyFrameType::PUSH_PROMISE: {
result = SpdyMakeUnique<SpdyPushPromiseFrameIterator>( return SpdyMakeUnique<SpdyPushPromiseFrameIterator>(
framer, SpdyWrapUnique(static_cast<const SpdyPushPromiseIR*>( framer, SpdyWrapUnique(static_cast<const SpdyPushPromiseIR*>(
frame_ir.release()))); frame_ir.release())));
break;
} }
case SpdyFrameType::DATA: { case SpdyFrameType::DATA: {
DVLOG(1) << "Serialize a stream end DATA frame for VTL"; DVLOG(1) << "Serialize a stream end DATA frame for VTL";
// FALLTHROUGH_INTENDED // FALLTHROUGH_INTENDED
} }
default: { default: {
result = return SpdyMakeUnique<SpdyControlFrameIterator>(framer,
SpdyMakeUnique<SpdyControlFrameIterator>(framer, std::move(frame_ir)); std::move(frame_ir));
} }
} }
return result;
} }
void SpdyFramer::SerializeDataBuilderHelper(const SpdyDataIR& data_ir, void SpdyFramer::SerializeDataBuilderHelper(const SpdyDataIR& data_ir,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment