Commit 38c1f949 authored by changwan's avatar changwan Committed by Commit bot

Fix TextInputManager for Android

In crrev.com/2354793003, we changed state updates to go through
TextInputManager, but TextInputManager does not propagate state update
when the current and last state was NONE. This can cause IME thread to
hang because it waits for the request to be replied.

BUG=699699

Review-Url: https://codereview.chromium.org/2743933003
Cr-Commit-Position: refs/heads/master@{#456116}
parent d81b759b
...@@ -102,7 +102,11 @@ void TextInputManager::UpdateTextInputState( ...@@ -102,7 +102,11 @@ void TextInputManager::UpdateTextInputState(
// already synthesized the loss of TextInputState for the |view| before (see // already synthesized the loss of TextInputState for the |view| before (see
// below). So we can forget about this method ever being called (no observer // below). So we can forget about this method ever being called (no observer
// calls necessary). // calls necessary).
// NOTE: Android requires state to be returned even when the current state
// is/becomes NONE. Otherwise IME may become irresponsive.
#if !defined(OS_ANDROID)
return; return;
#endif
} }
// Since |view| is registered, we already have a previous value for its // Since |view| is registered, we already have a previous value for its
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment