Commit 38f1aa59 authored by Shimi Zhang's avatar Shimi Zhang Committed by Commit Bot

Fix some lint exceptions by adding RESOLVING_LONG_PRESS to @IntDef

Bug: None
Change-Id: Iaa4911dc743216c9fde6d44b3677e6d0951b64a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350246
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797379}
parent f2a1414a
......@@ -258,72 +258,6 @@
column="53"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS"
errorLine1=" || mSelectionController.getSelectionType() == SelectionType.RESOLVING_LONG_PRESS;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java"
line="460"
column="63"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS"
errorLine1=" == SelectionType.RESOLVING_LONG_PRESS)) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java"
line="784"
column="36"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS"
errorLine1=" if (mSelectionController.getSelectionType() == SelectionType.RESOLVING_LONG_PRESS) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java"
line="1375"
column="56"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS"
errorLine1=" == SelectionType.RESOLVING_LONG_PRESS;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java"
line="1598"
column="36"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS"
errorLine1=" == SelectionType.RESOLVING_LONG_PRESS) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java"
line="1633"
column="36"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS"
errorLine1=" || mSelectionController.getSelectionType() == SelectionType.RESOLVING_LONG_PRESS"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java"
line="138"
column="63"/>
</issue>
<issue
id="WrongConstant"
message="Must be one of: TabLaunchType.FROM_LINK, TabLaunchType.FROM_EXTERNAL_APP, TabLaunchType.FROM_CHROME_UI, TabLaunchType.FROM_RESTORE, TabLaunchType.FROM_LONGPRESS_FOREGROUND, TabLaunchType.FROM_LONGPRESS_BACKGROUND, TabLaunchType.FROM_REPARENTING, TabLaunchType.FROM_LAUNCHER_SHORTCUT, TabLaunchType.FROM_SPECULATIVE_BACKGROUND_CREATION, TabLaunchType.FROM_BROWSER_ACTIONS, TabLaunchType.FROM_LAUNCH_NEW_INCOGNITO_TAB, TabLaunchType.FROM_STARTUP, TabLaunchType.FROM_START_SURFACE, TabLaunchType.SIZE"
......
......@@ -34,7 +34,8 @@ public class ContextualSearchSelectionController {
/**
* The type of selection made by the user.
*/
@IntDef({SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS})
@IntDef({SelectionType.UNDETERMINED, SelectionType.TAP, SelectionType.LONG_PRESS,
SelectionType.RESOLVING_LONG_PRESS})
@Retention(RetentionPolicy.SOURCE)
public @interface SelectionType {
int UNDETERMINED = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment