Instant Tethering: Rewrite the ConnectTetheringOperation unittest.

Such that the tests no longer depend on BleConnectionManager.

* Remove as much simulation using dependent objects as possible.
* Directly call methods under test.
* Remove irrelevant tests.

R=khorimoto@chromium.org

Bug: none
Test: ConnectTetheringOperationTest.*
Change-Id: I7f6c69e90dfe2f4d3006067de92db0973486c4d4
Reviewed-on: https://chromium-review.googlesource.com/c/1351478
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612368}

chromeos/components/tether/connect_tethering_operation.h

@@ -5,6 +5,8 @@
 #ifndef CHROMEOS_COMPONENTS_TETHER_CONNECT_TETHERING_OPERATION_H_
 #define CHROMEOS_COMPONENTS_TETHER_CONNECT_TETHERING_OPERATION_H_
 
+#include <stdint.h>
+
 #include <map>
 #include <vector>
 
@@ -12,6 +14,7 @@
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "base/time/clock.h"
+#include "base/time/time.h"
 #include "chromeos/components/tether/message_transfer_operation.h"
 #include "components/cryptauth/remote_device_ref.h"
 
@@ -115,7 +118,17 @@ class ConnectTetheringOperation : public MessageTransferOperation {
  private:
   friend class ConnectTetheringOperationTest;
   FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest,
-                           TestOperation_SetupRequired);
+                           SuccessWithValidResponse);
+  FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest,
+                           SuccessButInvalidResponse);
+  FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest, UnknownError);
+  FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest, ProvisioningFailed);
+  FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest,
+                           NotifyConnectTetheringRequest);
+  FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest,
+                           GetMessageTimeoutSeconds);
+  FRIEND_TEST_ALL_PREFIXES(ConnectTetheringOperationTest,
+                           MessageSentOnceAuthenticated);
 
   HostResponseErrorCode ConnectTetheringResponseCodeToHostResponseErrorCode(
       ConnectTetheringResponse_ResponseCode error_code);
@@ -128,8 +141,6 @@ class ConnectTetheringOperation : public MessageTransferOperation {
   static const uint32_t kSetupRequiredResponseTimeoutSeconds;
 
   cryptauth::RemoteDeviceRef remote_device_;
-  device_sync::DeviceSyncClient* device_sync_client_;
-  secure_channel::SecureChannelClient* secure_channel_client_;
   TetherHostResponseRecorder* tether_host_response_recorder_;
   base::Clock* clock_;
   int connect_message_sequence_number_ = -1;