Commit 39048b5e authored by Robert Sesek's avatar Robert Sesek Committed by Commit Bot

apple: Convert GN libs lists to frameworks in //skia.

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: 1052560
Change-Id: I334e4309d9d5dfe1a0fb45836925dddc532b4fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277973
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Robert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarMike Klein <mtklein@google.com>
Cr-Commit-Position: refs/heads/master@{#784472}
parent a513821c
...@@ -552,7 +552,7 @@ component("skia") { ...@@ -552,7 +552,7 @@ component("skia") {
if (is_mac) { if (is_mac) {
deps += [ ":skia_metal" ] deps += [ ":skia_metal" ]
defines += [ "SK_METAL" ] defines += [ "SK_METAL" ]
libs = [ frameworks = [
"AppKit.framework", "AppKit.framework",
"CoreFoundation.framework", "CoreFoundation.framework",
"CoreGraphics.framework", "CoreGraphics.framework",
...@@ -565,7 +565,7 @@ component("skia") { ...@@ -565,7 +565,7 @@ component("skia") {
sources += skia_dawn_sources sources += skia_dawn_sources
} }
if (is_ios) { if (is_ios) {
libs = [ "ImageIO.framework" ] frameworks = [ "ImageIO.framework" ]
set_sources_assignment_filter([]) set_sources_assignment_filter([])
sources += [ sources += [
"//third_party/skia/src/utils/mac/SkCGBase.h", "//third_party/skia/src/utils/mac/SkCGBase.h",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment