Commit 392f6747 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Switch latency_perftests to histograms

Switches latency_perftests to use PerfResultReporter instead of
PrintResult and whitelists it for conversion to histograms before
uploading to the perf dashboard.

Shouldn't affect anything on the bots since these tests seem to
currently only be used for local testing.

Bug: 923564
Change-Id: I0386ad93c65e6bb79928f0f9c4fe4a2d27d9716e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793790Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697400}
parent f6b31ec0
......@@ -56,6 +56,7 @@ GTEST_CONVERSION_WHITELIST = [
'angle_perftests',
'cc_perftests',
'gpu_perftests',
'latency_perftests',
'media_perftests',
'views_perftests',
'xr.vr.common_perftests',
......
......@@ -10,7 +10,7 @@
#include "base/metrics/sample_vector.h"
#include "base/time/time.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/perf/perf_test.h"
#include "testing/perf/perf_result_reporter.h"
#include "ui/latency/fixed_point.h"
#include "ui/latency/frame_metrics_test_common.h"
......@@ -52,6 +52,12 @@ class RatioHistogramBaseline : public Histogram {
DISALLOW_COPY_AND_ASSIGN(RatioHistogramBaseline);
};
perf_test::PerfResultReporter SetUpReporter(const std::string& story_name) {
perf_test::PerfResultReporter reporter("FrameMetricsHistograms", story_name);
reporter.RegisterImportantMetric(".speedup", "score");
return reporter;
}
TEST(FrameMetricsHistogramsPerfTest, RatioEntireRange) {
const int kStride = 0x1000;
......@@ -90,8 +96,9 @@ TEST(FrameMetricsHistogramsPerfTest, RatioEntireRange) {
}
}
double X = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PrintResult(__FUNCTION__, "", __FUNCTION__, X, "x", true);
double speedup = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PerfResultReporter reporter = SetUpReporter("RatioEntireRange");
reporter.AddResult(".speedup", speedup);
}
TEST(FrameMetricsHistogramsPerfTest, RatioCommonRange) {
......@@ -132,8 +139,9 @@ TEST(FrameMetricsHistogramsPerfTest, RatioCommonRange) {
}
}
double X = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PrintResult(__FUNCTION__, "", __FUNCTION__, X, "x", true);
double speedup = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PerfResultReporter reporter = SetUpReporter("RatioCommonRange");
reporter.AddResult(".speedup", speedup);
}
// A version of VSyncHistogram based on the default implementations
......@@ -207,8 +215,9 @@ TEST(FrameMetricsHistogramsPerfTest, VSyncEntireRange) {
}
}
double X = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PrintResult(__FUNCTION__, "", __FUNCTION__, X, "x", true);
double speedup = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PerfResultReporter reporter = SetUpReporter("VSyncEntireRange");
reporter.AddResult(".speedup", speedup);
}
TEST(FrameMetricsHistogramsPerfTest, VSyncCommonRange) {
......@@ -249,8 +258,9 @@ TEST(FrameMetricsHistogramsPerfTest, VSyncCommonRange) {
}
}
double X = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PrintResult(__FUNCTION__, "", __FUNCTION__, X, "x", true);
double speedup = base_time.InSecondsF() / impl_time.InSecondsF();
perf_test::PerfResultReporter reporter = SetUpReporter("VSyncCommonRange");
reporter.AddResult(".speedup", speedup);
}
} // namespace frame_metrics
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment